Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement](statistics)Return -1 to neredis if report olap table row count for new table is not done for all tablets. #40457

Merged
merged 1 commit into from
Sep 7, 2024
Merged

[improvement](statistics)Return -1 to neredis if report olap table row count for new table is not done for all tablets. #40457

merged 1 commit into from
Sep 7, 2024

Conversation

Jibing-Li
Copy link
Contributor

Return -1 to neredis if report olap table row count for new table is not done for all tablets.
After this change, nereids could know new table is empty or not. When it's not empty but not reported yet, return -1 as row count to nereids.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Jibing-Li Jibing-Li marked this pull request as ready for review September 5, 2024 15:42
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38719 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b65fb5d928a4bdf857ede743d62358db904c03c8, data reload: false

------ Round 1 ----------------------------------
q1	17351	4555	4324	4324
q2	1665	326	328	326
q3	10992	988	1100	988
q4	10456	759	800	759
q5	7788	2914	2821	2821
q6	227	136	142	136
q7	990	612	645	612
q8	9326	2127	2116	2116
q9	7243	6646	6651	6646
q10	7058	2225	2335	2225
q11	454	240	238	238
q12	396	226	222	222
q13	18806	3085	3090	3085
q14	269	238	239	238
q15	561	499	510	499
q16	515	429	429	429
q17	1021	647	681	647
q18	7720	7009	7031	7009
q19	1386	963	987	963
q20	708	335	339	335
q21	3943	3192	3131	3131
q22	1103	970	997	970
Total cold run time: 109978 ms
Total hot run time: 38719 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4434	4313	4327	4313
q2	376	282	275	275
q3	2975	2658	2692	2658
q4	1949	1632	1700	1632
q5	5695	5723	5854	5723
q6	223	132	139	132
q7	2263	1823	1809	1809
q8	3317	3450	3602	3450
q9	8923	8887	8955	8887
q10	3715	3371	3388	3371
q11	635	508	497	497
q12	831	655	666	655
q13	15500	3231	3308	3231
q14	333	295	294	294
q15	549	504	501	501
q16	575	532	489	489
q17	1952	1584	1513	1513
q18	8417	7935	8085	7935
q19	1739	1557	1552	1552
q20	2193	1926	1943	1926
q21	5706	5615	5460	5460
q22	1106	1019	1046	1019
Total cold run time: 73406 ms
Total hot run time: 57322 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.78% (9381/25507)
Line Coverage: 28.21% (77346/274192)
Region Coverage: 27.62% (39935/144585)
Branch Coverage: 24.26% (20322/83754)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b65fb5d928a4bdf857ede743d62358db904c03c8_b65fb5d928a4bdf857ede743d62358db904c03c8/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 192090 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b65fb5d928a4bdf857ede743d62358db904c03c8, data reload: false

query1	1747	841	858	841
query2	6335	1942	1906	1906
query3	10583	3990	4010	3990
query4	27455	23281	23074	23074
query5	3637	496	501	496
query6	246	166	177	166
query7	3070	307	306	306
query8	290	227	225	225
query9	6789	2520	2501	2501
query10	436	273	260	260
query11	17658	14908	15086	14908
query12	158	100	99	99
query13	1529	385	382	382
query14	9240	7422	6923	6923
query15	260	164	169	164
query16	7338	449	460	449
query17	1585	603	566	566
query18	1712	300	295	295
query19	219	148	146	146
query20	124	110	122	110
query21	212	109	116	109
query22	4776	4545	4701	4545
query23	34382	33852	34066	33852
query24	11376	2899	2821	2821
query25	582	374	381	374
query26	1011	152	155	152
query27	2202	266	276	266
query28	6882	2043	2041	2041
query29	714	395	403	395
query30	261	152	149	149
query31	962	765	761	761
query32	93	49	55	49
query33	718	285	278	278
query34	906	482	475	475
query35	856	703	708	703
query36	1081	911	898	898
query37	150	83	86	83
query38	4019	3858	3852	3852
query39	1419	1383	1394	1383
query40	198	113	120	113
query41	46	48	45	45
query42	112	100	94	94
query43	486	475	451	451
query44	1275	758	738	738
query45	192	161	161	161
query46	1097	711	752	711
query47	1947	1811	1843	1811
query48	366	289	313	289
query49	866	438	467	438
query50	844	413	427	413
query51	7058	6923	6816	6816
query52	101	88	85	85
query53	250	181	182	181
query54	975	477	477	477
query55	77	73	77	73
query56	278	304	269	269
query57	1165	1041	1083	1041
query58	229	236	222	222
query59	2969	2811	2694	2694
query60	289	263	261	261
query61	101	99	100	99
query62	820	663	664	663
query63	221	182	180	180
query64	4050	692	625	625
query65	3262	3119	3112	3112
query66	771	331	327	327
query67	15507	15460	15320	15320
query68	3931	576	558	558
query69	405	278	272	272
query70	1203	1138	1039	1039
query71	330	273	279	273
query72	6292	4009	4029	4009
query73	742	319	325	319
query74	9166	8654	8787	8654
query75	3424	2679	2667	2667
query76	2099	983	1013	983
query77	438	308	312	308
query78	10466	9356	9128	9128
query79	1074	564	525	525
query80	890	515	502	502
query81	559	229	226	226
query82	1111	142	145	142
query83	289	147	151	147
query84	223	75	73	73
query85	743	282	280	280
query86	311	279	302	279
query87	4336	4268	4201	4201
query88	3116	2353	2347	2347
query89	386	286	293	286
query90	1853	185	190	185
query91	120	97	100	97
query92	57	49	48	48
query93	1106	537	550	537
query94	750	286	272	272
query95	358	252	249	249
query96	581	260	261	260
query97	3226	3068	3067	3067
query98	221	199	210	199
query99	1779	1296	1256	1256
Total cold run time: 280150 ms
Total hot run time: 192090 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b65fb5d928a4bdf857ede743d62358db904c03c8, data reload: false

query1	0.19	0.19	0.18
query2	0.08	0.03	0.04
query3	0.22	0.05	0.05
query4	1.67	0.08	0.07
query5	0.52	0.48	0.49
query6	1.12	0.72	0.72
query7	0.08	0.04	0.04
query8	0.05	0.04	0.04
query9	0.95	0.90	0.89
query10	0.55	0.59	0.52
query11	0.16	0.12	0.12
query12	0.15	0.13	0.12
query13	0.61	0.60	0.58
query14	1.42	1.40	1.40
query15	0.85	0.82	0.81
query16	0.38	0.38	0.37
query17	1.05	1.02	0.97
query18	0.21	0.20	0.21
query19	1.82	1.77	1.71
query20	0.01	0.01	0.01
query21	15.39	0.66	0.65
query22	4.18	7.58	1.72
query23	18.25	1.39	1.30
query24	2.07	0.22	0.21
query25	0.15	0.09	0.08
query26	0.27	0.19	0.17
query27	0.08	0.08	0.07
query28	13.30	1.02	1.00
query29	12.59	3.31	3.31
query30	0.25	0.05	0.06
query31	2.86	0.40	0.39
query32	3.25	0.48	0.48
query33	2.96	2.96	3.05
query34	16.78	4.33	4.37
query35	4.48	4.41	4.42
query36	0.65	0.50	0.48
query37	0.19	0.16	0.16
query38	0.16	0.16	0.15
query39	0.05	0.03	0.04
query40	0.15	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.06	0.05
query43	0.04	0.04	0.05
Total cold run time: 110.35 s
Total hot run time: 31.52 s

@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.87% (9382/25449)
Line Coverage: 28.25% (77374/273933)
Region Coverage: 27.64% (39949/144533)
Branch Coverage: 24.28% (20335/83768)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3bd6b9c627f8fb750a01c4010738803596d8bfa6_3bd6b9c627f8fb750a01c4010738803596d8bfa6/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 38038 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3bd6b9c627f8fb750a01c4010738803596d8bfa6, data reload: false

------ Round 1 ----------------------------------
q1	18558	4736	4452	4452
q2	2894	188	186	186
q3	10807	1136	1082	1082
q4	11794	759	664	664
q5	8254	2912	2820	2820
q6	227	138	138	138
q7	963	617	594	594
q8	9332	2109	2071	2071
q9	7015	6540	6591	6540
q10	7014	2250	2166	2166
q11	447	242	252	242
q12	404	223	215	215
q13	18523	3072	3077	3072
q14	272	234	255	234
q15	552	482	480	480
q16	537	419	424	419
q17	980	689	703	689
q18	7575	6738	6923	6738
q19	1398	956	1066	956
q20	699	334	327	327
q21	4010	3232	2926	2926
q22	1129	1047	1027	1027
Total cold run time: 113384 ms
Total hot run time: 38038 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4369	4314	4351	4314
q2	386	273	273	273
q3	2908	2668	2698	2668
q4	1952	1648	1676	1648
q5	5422	5418	5393	5393
q6	219	129	129	129
q7	2125	1763	1796	1763
q8	3240	3367	3334	3334
q9	8449	8508	8444	8444
q10	3470	3171	3181	3171
q11	597	495	501	495
q12	806	621	603	603
q13	12700	3107	3077	3077
q14	297	277	277	277
q15	527	475	477	475
q16	508	470	495	470
q17	1803	1497	1480	1480
q18	7744	7463	7406	7406
q19	1694	1648	1567	1567
q20	2046	1793	1860	1793
q21	5335	5401	5255	5255
q22	1159	1028	1035	1028
Total cold run time: 67756 ms
Total hot run time: 55063 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187777 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3bd6b9c627f8fb750a01c4010738803596d8bfa6, data reload: false

query1	928	371	378	371
query2	6517	1907	1829	1829
query3	6652	207	218	207
query4	28805	23266	23049	23049
query5	4152	503	487	487
query6	265	165	179	165
query7	4584	304	293	293
query8	294	240	206	206
query9	8520	2459	2468	2459
query10	446	285	279	279
query11	17802	14996	14919	14919
query12	166	106	106	106
query13	1620	376	362	362
query14	9442	7208	6993	6993
query15	294	173	170	170
query16	7555	467	456	456
query17	1601	570	565	565
query18	1936	293	303	293
query19	339	153	149	149
query20	121	109	112	109
query21	210	106	106	106
query22	4453	4180	4335	4180
query23	34481	33326	33492	33326
query24	11240	2819	2797	2797
query25	639	389	394	389
query26	1220	151	152	151
query27	2685	277	270	270
query28	7413	2046	2046	2046
query29	836	405	400	400
query30	313	161	150	150
query31	993	750	772	750
query32	93	54	54	54
query33	757	280	275	275
query34	986	479	472	472
query35	837	710	719	710
query36	1086	905	932	905
query37	151	88	81	81
query38	4025	3842	3887	3842
query39	1445	1409	1391	1391
query40	269	114	112	112
query41	48	43	44	43
query42	113	97	92	92
query43	500	483	479	479
query44	1249	742	731	731
query45	203	166	169	166
query46	1104	735	744	735
query47	1891	1836	1835	1835
query48	370	279	279	279
query49	1081	434	436	434
query50	821	404	401	401
query51	6950	6830	6887	6830
query52	96	85	88	85
query53	258	180	182	180
query54	1016	456	456	456
query55	80	73	75	73
query56	293	249	260	249
query57	1210	1092	1065	1065
query58	246	245	232	232
query59	2950	2787	2821	2787
query60	288	256	272	256
query61	108	101	102	101
query62	822	663	674	663
query63	228	185	180	180
query64	5196	680	697	680
query65	3244	3118	3174	3118
query66	1419	337	323	323
query67	15661	15475	15506	15475
query68	3539	588	554	554
query69	390	273	277	273
query70	1185	1104	1038	1038
query71	345	279	272	272
query72	6263	3987	4067	3987
query73	737	325	325	325
query74	9294	8878	8792	8792
query75	3350	2690	2737	2690
query76	1849	981	989	981
query77	498	327	316	316
query78	9748	9505	9831	9505
query79	1088	539	528	528
query80	709	507	522	507
query81	489	232	231	231
query82	244	146	139	139
query83	172	157	160	157
query84	221	75	78	75
query85	947	301	284	284
query86	334	288	283	283
query87	4465	4313	4263	4263
query88	2897	2279	2275	2275
query89	373	293	286	286
query90	1985	192	191	191
query91	129	99	105	99
query92	67	50	50	50
query93	1023	556	532	532
query94	883	296	290	290
query95	347	249	253	249
query96	583	259	258	258
query97	3227	3091	3071	3071
query98	219	201	210	201
query99	1480	1284	1253	1253
Total cold run time: 282696 ms
Total hot run time: 187777 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.38 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3bd6b9c627f8fb750a01c4010738803596d8bfa6, data reload: false

query1	0.04	0.05	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.06
query4	1.67	0.08	0.07
query5	0.51	0.51	0.50
query6	1.12	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.54	0.49	0.49
query10	0.54	0.55	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.60	0.59	0.58
query14	1.38	1.42	1.44
query15	0.87	0.84	0.81
query16	0.37	0.37	0.38
query17	1.02	1.05	1.04
query18	0.20	0.20	0.21
query19	1.93	1.85	1.83
query20	0.01	0.01	0.01
query21	15.41	0.67	0.66
query22	4.36	7.40	1.88
query23	18.32	1.40	1.27
query24	2.11	0.23	0.22
query25	0.15	0.09	0.08
query26	0.26	0.18	0.17
query27	0.08	0.07	0.07
query28	13.22	1.02	0.99
query29	12.63	3.31	3.32
query30	0.24	0.06	0.05
query31	2.90	0.40	0.39
query32	3.24	0.48	0.48
query33	2.99	2.96	2.99
query34	17.00	4.38	4.37
query35	4.42	4.42	4.46
query36	0.67	0.48	0.48
query37	0.18	0.16	0.15
query38	0.15	0.14	0.14
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.21 s
Total hot run time: 31.38 s

@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37575 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ccaeccbafb905e81159dde6800e96c190e4b4db5, data reload: false

------ Round 1 ----------------------------------
q1	18528	6828	4312	4312
q2	2029	190	180	180
q3	11666	981	1061	981
q4	10446	648	809	648
q5	7724	2837	2763	2763
q6	228	136	140	136
q7	971	620	626	620
q8	9327	2065	2055	2055
q9	7161	6520	6524	6520
q10	6981	2321	2156	2156
q11	452	245	245	245
q12	394	226	222	222
q13	17898	3132	3064	3064
q14	285	230	256	230
q15	528	488	485	485
q16	525	439	462	439
q17	980	666	684	666
q18	7399	6825	6935	6825
q19	1391	956	1032	956
q20	688	326	337	326
q21	3937	2789	2725	2725
q22	1139	1021	1034	1021
Total cold run time: 110677 ms
Total hot run time: 37575 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4407	4310	4267	4267
q2	375	267	275	267
q3	2872	2706	2652	2652
q4	1898	1609	1670	1609
q5	5703	5668	5796	5668
q6	226	130	138	130
q7	2202	1834	1805	1805
q8	3301	3439	3489	3439
q9	8871	8820	8744	8744
q10	3625	3347	3376	3347
q11	608	516	511	511
q12	822	680	685	680
q13	14591	3278	3302	3278
q14	321	290	280	280
q15	542	476	527	476
q16	536	503	489	489
q17	1819	1543	1540	1540
q18	8162	7949	7847	7847
q19	1708	1463	1507	1463
q20	2142	1921	1929	1921
q21	5674	5452	5472	5452
q22	1116	1048	996	996
Total cold run time: 71521 ms
Total hot run time: 56861 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192035 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ccaeccbafb905e81159dde6800e96c190e4b4db5, data reload: false

query1	1253	895	865	865
query2	6349	1925	1846	1846
query3	10587	4099	3909	3909
query4	59951	23699	23003	23003
query5	5433	517	502	502
query6	412	163	158	158
query7	5790	292	292	292
query8	322	232	230	230
query9	8969	2484	2474	2474
query10	481	280	265	265
query11	16521	14935	15066	14935
query12	160	109	107	107
query13	1581	392	377	377
query14	10576	7476	7741	7476
query15	262	175	204	175
query16	7038	477	468	468
query17	1154	592	561	561
query18	1232	291	298	291
query19	284	149	154	149
query20	123	108	108	108
query21	217	102	106	102
query22	4577	4639	4591	4591
query23	34223	33262	33834	33262
query24	5995	2787	2754	2754
query25	517	374	383	374
query26	683	150	155	150
query27	1783	271	276	271
query28	3884	2044	2028	2028
query29	635	409	403	403
query30	241	157	152	152
query31	943	776	769	769
query32	86	53	55	53
query33	439	289	290	289
query34	887	482	476	476
query35	839	712	719	712
query36	1049	914	965	914
query37	146	89	84	84
query38	4040	3884	3902	3884
query39	1513	1395	1385	1385
query40	197	112	113	112
query41	46	48	45	45
query42	115	94	93	93
query43	494	473	465	465
query44	1113	750	741	741
query45	195	167	165	165
query46	1085	755	734	734
query47	1912	1756	1839	1756
query48	367	295	294	294
query49	756	448	439	439
query50	825	400	411	400
query51	7056	6912	6893	6893
query52	102	86	88	86
query53	244	178	177	177
query54	559	447	449	447
query55	74	74	78	74
query56	273	257	257	257
query57	1183	1089	1059	1059
query58	209	224	225	224
query59	3030	2931	2688	2688
query60	291	262	272	262
query61	105	105	101	101
query62	723	639	660	639
query63	210	184	182	182
query64	2806	676	657	657
query65	3227	3113	3117	3113
query66	622	332	330	330
query67	15427	15290	15285	15285
query68	2987	587	582	582
query69	394	279	290	279
query70	1196	1145	1102	1102
query71	350	283	280	280
query72	6241	4005	4032	4005
query73	738	319	323	319
query74	9080	8859	8799	8799
query75	3340	2735	2675	2675
query76	1541	947	990	947
query77	533	318	317	317
query78	9695	9036	8973	8973
query79	1042	547	533	533
query80	688	511	513	511
query81	533	231	225	225
query82	278	141	132	132
query83	166	154	154	154
query84	266	72	77	72
query85	685	289	289	289
query86	298	294	291	291
query87	4309	4238	4351	4238
query88	2957	2269	2282	2269
query89	386	281	294	281
query90	1958	190	187	187
query91	121	96	97	96
query92	59	49	50	49
query93	1060	530	531	530
query94	657	284	362	284
query95	329	250	252	250
query96	585	260	268	260
query97	3229	3075	3107	3075
query98	212	202	203	202
query99	1717	1310	1267	1267
Total cold run time: 302051 ms
Total hot run time: 192035 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.36 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ccaeccbafb905e81159dde6800e96c190e4b4db5, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.04
query4	1.68	0.08	0.07
query5	0.51	0.49	0.48
query6	1.14	0.73	0.73
query7	0.01	0.02	0.02
query8	0.06	0.04	0.05
query9	0.55	0.49	0.48
query10	0.54	0.56	0.54
query11	0.16	0.12	0.12
query12	0.15	0.12	0.11
query13	0.60	0.58	0.58
query14	1.41	1.43	1.44
query15	0.84	0.82	0.81
query16	0.37	0.36	0.37
query17	0.98	0.99	1.03
query18	0.21	0.19	0.20
query19	1.75	1.78	1.72
query20	0.01	0.01	0.01
query21	15.40	0.68	0.66
query22	3.93	6.62	2.01
query23	18.30	1.34	1.29
query24	2.07	0.22	0.21
query25	0.16	0.08	0.08
query26	0.26	0.18	0.18
query27	0.07	0.08	0.08
query28	13.26	1.03	0.99
query29	12.60	3.35	3.32
query30	0.25	0.06	0.05
query31	2.88	0.40	0.40
query32	3.26	0.48	0.48
query33	2.94	3.00	2.99
query34	17.02	4.44	4.34
query35	4.46	4.43	4.41
query36	0.65	0.47	0.48
query37	0.19	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.15	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.59 s
Total hot run time: 31.36 s

morrySnow
morrySnow previously approved these changes Sep 6, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.86% (9380/25450)
Line Coverage: 28.23% (77349/273967)
Region Coverage: 27.63% (39944/144547)
Branch Coverage: 24.27% (20328/83774)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ccaeccbafb905e81159dde6800e96c190e4b4db5_ccaeccbafb905e81159dde6800e96c190e4b4db5/report/index.html

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 6, 2024
yiguolei added a commit that referenced this pull request Sep 10, 2024
@yiguolei
Revert "[improvement](statistics)Return -1 to neredis if report olap …
4e453dc 
…table row count for new table is not done for all tablets. (#40457)" (#40616)

Reverts #40540
hello-stephen added a commit that referenced this pull request Sep 10, 2024
@hello-stephen
Revert "[improvement](statistics)Return -1 to neredis if report olap …
28bceac 
…table row count for new table is not done for all tablets. (#40457)" (#40617)

Reverts #40538
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Sep 14, 2024
@Jibing-Li
[improvement](statistics)Return -1 to neredis if report olap table ro…
9cb425b 
…w count for new table is not done for all tablets. (apache#40457)

Return -1 to neredis if report olap table row count for new table is not
done for all tablets.
After this change, nereids could know new table is empty or not. When
it's not empty but not reported yet, return -1 as row count to nereids.
@Jibing-Li Jibing-Li mentioned this pull request Sep 14, 2024
Merged
Jibing-Li added a commit that referenced this pull request Sep 14, 2024
@Jibing-Li
[improvement](statistics)Return -1 to neredis if report olap table ro…
0b1d517 
…w count for new table is not done for all tablets. (#40457) (#40838)

backport: #40457
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Sep 19, 2024
@Jibing-Li
[improvement](statistics)Return -1 to neredis if report olap table ro…
35aa6d5 
…w count for new table is not done for all tablets. (apache#40457)

Return -1 to neredis if report olap table row count for new table is not
done for all tablets.
After this change, nereids could know new table is empty or not. When
it's not empty but not reported yet, return -1 as row count to nereids.
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Sep 19, 2024
@Jibing-Li
[improvement](statistics)Return -1 to neredis if report olap table ro…
c4c94c8 
…w count for new table is not done for all tablets. (apache#40457)

Return -1 to neredis if report olap table row count for new table is not
done for all tablets.
After this change, nereids could know new table is empty or not. When
it's not empty but not reported yet, return -1 as row count to nereids.
This was referenced Sep 19, 2024
Merged
Merged
Jibing-Li added a commit that referenced this pull request Sep 24, 2024
@Jibing-Li
[improvement](statistics)Support cloud version set row count to -1 wh…
0b92e5a 
…en not reported. (#41015)

Follow up #40457. Support cloud
version.
Jibing-Li added a commit that referenced this pull request Sep 26, 2024
@Jibing-Li
[improvement](statistics)Return -1 to neredis if report olap table ro…
2f5be08 
…w count for new table is not done for all tablets. (#40457) (#40973)

backport: #40457
Jibing-Li added a commit that referenced this pull request Oct 8, 2024
@Jibing-Li
[improvement](statistics)Return -1 to neredis if report olap table ro…
769f2c0 
…w count for new table is not done for all tablets. (#40457) (#40973)

backport: #40457
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 15, 2024
@Jibing-Li
[improvement](statistics)Return -1 to neredis if report olap table ro…
9d5f4a8 
…w count for new table is not done for all tablets. (apache#40457)

Return -1 to neredis if report olap table row count for new table is not
done for all tablets.
After this change, nereids could know new table is empty or not. When
it's not empty but not reported yet, return -1 as row count to nereids.
@Jibing-Li Jibing-Li mentioned this pull request Oct 15, 2024
Merged
Jibing-Li added a commit that referenced this pull request Oct 15, 2024
@Jibing-Li
[improvement](statistics)Return -1 to neredis if report olap table ro…
8b4a1a9 
…w count for new table is not done for all tablets. (#40457) (#41884)

backport: #40457
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 16, 2024
@Jibing-Li
[improvement](statistics)Support cloud version set row count to -1 wh…
c22625a 
…en not reported. (apache#41015)

Follow up apache#40457. Support cloud
version.
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 16, 2024
@Jibing-Li
[improvement](statistics)Support cloud version set row count to -1 wh…
e20d5ad 
…en not reported. (apache#41015)

Follow up apache#40457. Support cloud
version.
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Open
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@englefly englefly englefly approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.16-merged dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jibing-Li @doris-robot @englefly @morrySnow @yiguolei @dataroaring