Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](function) Optimize ConvertTz function when using constant parameters. #40366

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[opt](function) Optimize ConvertTz function when using constant parameters. #40366

merged 2 commits into from
Sep 10, 2024

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Sep 4, 2024 •
edited
Loading

Proposed changes

mysql [test]>select count(convert_tz(d, 'Asia/Shanghai', 'America/Los_Angeles')), count(convert_tz(dt, 'America/Los_Angeles', '+00:00')) from dates; 
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
| count(convert_tz(cast(d as DATETIMEV2(6)), 'Asia/Shanghai', 'America/Los_Angeles')) | count(convert_tz(dt, 'America/Los_Angeles', '+00:00')) |
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
|                                                                            16000000 |                                               16000000 |
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
1 row in set (13.91 sec)

mysql [test]>select count(convert_tz(d, 'Asia/Shanghai', 'America/Los_Angeles')), count(convert_tz(dt, 'America/Los_Angeles', '+00:00')) from dates;
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
| count(convert_tz(cast(d as DATETIMEV2(6)), 'Asia/Shanghai', 'America/Los_Angeles')) | count(convert_tz(dt, 'America/Los_Angeles', '+00:00')) |
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
|                                                                            16000000 |                                               16000000 |
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
1 row in set (4.59 sec)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Sep 4, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.84% (9393/25499)
Line Coverage: 28.27% (77456/274035)
Region Coverage: 27.67% (39976/144487)
Branch Coverage: 24.31% (20341/83672)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e_9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 37776 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, data reload: false

------ Round 1 ----------------------------------
q1	17607	4433	4342	4342
q2	2018	202	172	172
q3	11642	934	1147	934
q4	10523	715	683	683
q5	7735	2830	2788	2788
q6	224	139	144	139
q7	947	607	598	598
q8	9324	2040	2082	2040
q9	7119	6516	6491	6491
q10	7002	2198	2174	2174
q11	454	248	247	247
q12	396	233	238	233
q13	17766	3035	3079	3035
q14	273	236	236	236
q15	540	496	494	494
q16	598	505	511	505
q17	958	743	743	743
q18	7321	6780	6952	6780
q19	1385	1050	1038	1038
q20	647	339	330	330
q21	4025	3013	2764	2764
q22	1092	1027	1010	1010
Total cold run time: 109596 ms
Total hot run time: 37776 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4325	4333	4278	4278
q2	372	280	275	275
q3	2851	2608	2625	2608
q4	1941	1655	1657	1655
q5	5574	5646	5689	5646
q6	222	134	137	134
q7	2295	1814	1823	1814
q8	3308	3421	3421	3421
q9	8834	8742	8792	8742
q10	3496	3376	3353	3353
q11	631	519	512	512
q12	793	667	670	667
q13	15168	3244	3299	3244
q14	318	304	291	291
q15	539	502	493	493
q16	613	594	602	594
q17	1838	1566	1572	1566
q18	8203	7793	7832	7793
q19	1733	1659	1438	1438
q20	2164	1916	1882	1882
q21	5680	5468	5410	5410
q22	1129	1059	1064	1059
Total cold run time: 72027 ms
Total hot run time: 56875 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193148 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, data reload: false

query1	1251	889	862	862
query2	6354	1881	1846	1846
query3	10604	3975	4033	3975
query4	59649	25867	23491	23491
query5	5407	507	489	489
query6	407	173	165	165
query7	5871	305	288	288
query8	285	216	214	214
query9	9119	2514	2505	2505
query10	504	285	260	260
query11	17179	15102	15427	15102
query12	146	103	99	99
query13	1571	403	377	377
query14	11107	7590	7295	7295
query15	246	172	183	172
query16	7444	479	463	463
query17	1167	584	585	584
query18	1808	302	309	302
query19	283	171	156	156
query20	120	113	118	113
query21	210	106	109	106
query22	4522	4401	4452	4401
query23	34309	33578	33720	33578
query24	5906	2891	2855	2855
query25	557	410	391	391
query26	686	154	156	154
query27	1801	286	279	279
query28	3895	2055	2031	2031
query29	683	424	433	424
query30	242	155	152	152
query31	933	767	792	767
query32	83	54	54	54
query33	484	301	291	291
query34	842	479	477	477
query35	831	732	750	732
query36	1075	941	914	914
query37	149	101	93	93
query38	4053	3908	3935	3908
query39	1449	1395	1387	1387
query40	196	115	116	115
query41	47	50	45	45
query42	125	96	99	96
query43	506	452	486	452
query44	1102	743	751	743
query45	196	166	166	166
query46	1105	749	754	749
query47	1916	1790	1838	1790
query48	378	303	295	295
query49	764	437	439	437
query50	806	424	426	424
query51	6947	6999	6892	6892
query52	99	94	93	93
query53	254	176	181	176
query54	578	468	465	465
query55	76	78	77	77
query56	293	264	276	264
query57	1177	1063	1087	1063
query58	226	273	228	228
query59	2974	2800	2792	2792
query60	305	282	302	282
query61	126	124	120	120
query62	775	656	654	654
query63	214	193	192	192
query64	2989	663	699	663
query65	3185	3137	3180	3137
query66	698	339	342	339
query67	15291	15211	15057	15057
query68	4405	569	557	557
query69	429	283	296	283
query70	1192	1072	1044	1044
query71	370	279	284	279
query72	6562	3975	3941	3941
query73	739	319	329	319
query74	9319	8862	8926	8862
query75	3325	2665	2693	2665
query76	1740	1068	983	983
query77	529	321	316	316
query78	10533	9093	9078	9078
query79	1174	532	544	532
query80	784	499	545	499
query81	562	234	236	234
query82	251	138	146	138
query83	223	148	147	147
query84	260	74	88	74
query85	838	295	275	275
query86	363	300	289	289
query87	4448	4243	4329	4243
query88	3869	2360	2335	2335
query89	380	289	279	279
query90	2007	191	192	191
query91	123	99	103	99
query92	57	50	51	50
query93	1146	535	538	535
query94	761	337	294	294
query95	354	256	248	248
query96	579	264	269	264
query97	3183	3110	3086	3086
query98	216	214	199	199
query99	1779	1297	1252	1252
Total cold run time: 309080 ms
Total hot run time: 193148 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.08	0.08
query5	0.51	0.49	0.50
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.55	0.47	0.48
query10	0.54	0.54	0.55
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.62	0.59	0.58
query14	2.10	2.05	2.06
query15	0.90	0.82	0.84
query16	0.35	0.38	0.38
query17	1.05	1.05	1.06
query18	0.21	0.21	0.21
query19	1.84	1.73	1.81
query20	0.02	0.01	0.01
query21	15.40	0.68	0.66
query22	4.23	7.17	1.89
query23	18.27	1.36	1.41
query24	1.86	0.29	0.23
query25	0.14	0.09	0.08
query26	0.28	0.18	0.18
query27	0.07	0.09	0.07
query28	13.24	1.03	1.01
query29	12.62	3.39	3.39
query30	0.24	0.06	0.05
query31	2.88	0.41	0.40
query32	3.23	0.48	0.48
query33	2.98	3.07	3.03
query34	17.16	4.41	4.42
query35	4.44	4.44	4.42
query36	0.66	0.50	0.49
query37	0.18	0.15	0.16
query38	0.16	0.16	0.15
query39	0.06	0.03	0.04
query40	0.16	0.13	0.13
query41	0.09	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.69 s
Total hot run time: 32.29 s

@Mryange
Copy link
Contributor Author

Mryange commented Sep 4, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37967 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, data reload: false

------ Round 1 ----------------------------------
q1	17648	4367	4290	4290
q2	2019	177	184	177
q3	11821	977	1140	977
q4	10530	721	666	666
q5	7761	2870	2828	2828
q6	231	140	140	140
q7	956	619	629	619
q8	9348	2046	2072	2046
q9	7161	6565	6584	6565
q10	6992	2219	2258	2219
q11	469	236	240	236
q12	397	219	220	219
q13	17766	3083	3114	3083
q14	277	231	235	231
q15	527	491	501	491
q16	600	504	506	504
q17	980	709	731	709
q18	7241	6943	6846	6846
q19	1378	1009	1015	1009
q20	686	334	328	328
q21	4521	3171	2804	2804
q22	1118	1028	980	980
Total cold run time: 110427 ms
Total hot run time: 37967 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4356	4349	4295	4295
q2	383	271	261	261
q3	2893	2631	2629	2629
q4	1928	1644	1668	1644
q5	5631	5678	5729	5678
q6	230	140	137	137
q7	2246	1838	1812	1812
q8	3321	3444	3454	3444
q9	8904	8884	8849	8849
q10	3551	3400	3410	3400
q11	618	509	516	509
q12	839	660	691	660
q13	13306	3364	3311	3311
q14	336	281	305	281
q15	536	487	487	487
q16	601	596	576	576
q17	1848	1550	1539	1539
q18	8168	7824	7896	7824
q19	1710	1501	1590	1501
q20	2152	1909	1935	1909
q21	5875	5465	5510	5465
q22	1141	1061	1034	1034
Total cold run time: 70573 ms
Total hot run time: 57245 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192275 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, data reload: false

query1	1241	895	876	876
query2	6302	1952	1892	1892
query3	10734	4036	4119	4036
query4	60086	26668	23101	23101
query5	5448	509	493	493
query6	408	177	165	165
query7	5763	326	288	288
query8	295	210	211	210
query9	8953	2549	2470	2470
query10	479	268	262	262
query11	18555	15038	15537	15038
query12	155	101	99	99
query13	1554	403	378	378
query14	11104	7586	6674	6674
query15	221	183	187	183
query16	7017	473	522	473
query17	1128	600	596	596
query18	1920	303	315	303
query19	295	155	150	150
query20	122	115	111	111
query21	216	106	110	106
query22	4661	4376	4565	4376
query23	34578	33417	33601	33417
query24	5969	2910	2789	2789
query25	535	402	408	402
query26	667	157	157	157
query27	1745	281	284	281
query28	3770	2058	2049	2049
query29	666	433	423	423
query30	240	154	147	147
query31	918	744	774	744
query32	82	54	56	54
query33	448	300	290	290
query34	852	481	475	475
query35	853	735	713	713
query36	1062	932	939	932
query37	148	94	95	94
query38	4039	3898	3885	3885
query39	1439	1402	1422	1402
query40	210	123	115	115
query41	50	47	46	46
query42	114	93	96	93
query43	505	484	473	473
query44	1094	742	744	742
query45	208	177	176	176
query46	1116	723	748	723
query47	1912	1778	1822	1778
query48	379	305	292	292
query49	767	448	446	446
query50	811	428	412	412
query51	7001	6908	6853	6853
query52	98	90	88	88
query53	257	186	180	180
query54	574	465	459	459
query55	74	76	74	74
query56	285	274	262	262
query57	1176	1080	1080	1080
query58	228	232	241	232
query59	3051	2881	2744	2744
query60	314	364	274	274
query61	102	99	99	99
query62	750	655	631	631
query63	232	180	184	180
query64	2552	682	703	682
query65	3212	3139	3168	3139
query66	617	345	336	336
query67	15503	15140	15274	15140
query68	4453	573	556	556
query69	418	286	272	272
query70	1210	1161	1149	1149
query71	372	274	275	274
query72	6650	4050	4116	4050
query73	781	321	326	321
query74	9262	9061	9066	9061
query75	3321	2703	2696	2696
query76	1784	1042	1061	1042
query77	525	314	326	314
query78	11456	9597	9033	9033
query79	2574	518	534	518
query80	1013	490	503	490
query81	570	229	237	229
query82	686	143	135	135
query83	243	151	145	145
query84	268	76	127	76
query85	703	291	281	281
query86	401	300	292	292
query87	4514	4344	4282	4282
query88	3578	2354	2332	2332
query89	394	277	287	277
query90	1829	194	188	188
query91	128	104	97	97
query92	62	49	51	49
query93	1745	541	533	533
query94	746	287	280	280
query95	344	245	254	245
query96	596	261	265	261
query97	3186	3065	3061	3061
query98	225	203	208	203
query99	1840	1276	1250	1250
Total cold run time: 313737 ms
Total hot run time: 192275 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, data reload: false

query1	0.04	0.05	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.08
query5	0.50	0.50	0.49
query6	1.12	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.55	0.50	0.49
query10	0.55	0.54	0.55
query11	0.15	0.12	0.10
query12	0.14	0.13	0.12
query13	0.59	0.58	0.59
query14	2.03	2.03	2.13
query15	0.90	0.82	0.81
query16	0.37	0.39	0.38
query17	1.06	1.06	1.04
query18	0.21	0.21	0.21
query19	1.80	1.90	1.75
query20	0.01	0.01	0.01
query21	15.40	0.68	0.66
query22	4.38	7.20	2.00
query23	18.21	1.34	1.30
query24	2.11	0.23	0.23
query25	0.14	0.08	0.08
query26	0.26	0.18	0.17
query27	0.08	0.08	0.07
query28	13.19	1.02	1.01
query29	12.62	3.38	3.37
query30	0.24	0.06	0.05
query31	2.87	0.41	0.39
query32	3.26	0.50	0.48
query33	3.07	2.96	3.04
query34	17.26	4.50	4.50
query35	4.54	4.54	4.58
query36	0.66	0.50	0.48
query37	0.19	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.15	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.06	0.05
query43	0.05	0.04	0.03
Total cold run time: 111.11 s
Total hot run time: 32.4 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.85% (9396/25501)
Line Coverage: 28.27% (77484/274047)
Region Coverage: 27.68% (39989/144493)
Branch Coverage: 24.32% (20352/83676)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e_9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e/report/index.html

HappenLee
HappenLee reviewed Sep 5, 2024
View reviewed changes
be/src/vec/functions/function_convert_tz.h Outdated
assert_cast<ColumnUInt8*>(result_null_map_column.get())->get_data(),
input_rows_count);
} else {
execute_tz_const(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the unless code

@Mryange
Copy link
Contributor Author

Mryange commented Sep 5, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37961 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c7a9c7f4b108883c07cb1a4de50b6812308cfb63, data reload: false

------ Round 1 ----------------------------------
q1	17781	5034	4343	4343
q2	2007	193	186	186
q3	11908	967	1222	967
q4	10511	750	798	750
q5	7771	2835	2801	2801
q6	232	139	137	137
q7	966	606	602	602
q8	9333	2092	2040	2040
q9	7248	6563	6573	6563
q10	7017	2211	2188	2188
q11	460	246	238	238
q12	397	231	225	225
q13	17768	3079	3078	3078
q14	292	238	251	238
q15	546	514	495	495
q16	610	508	511	508
q17	991	665	700	665
q18	7318	6767	6832	6767
q19	1408	1059	956	956
q20	678	342	337	337
q21	3899	2865	3132	2865
q22	1099	1012	1014	1012
Total cold run time: 110240 ms
Total hot run time: 37961 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4324	4269	4324	4269
q2	388	268	268	268
q3	2893	2691	2633	2633
q4	1918	1673	1686	1673
q5	5654	5688	5714	5688
q6	231	138	144	138
q7	2257	1859	1818	1818
q8	3300	3396	3476	3396
q9	8889	8847	8872	8847
q10	3590	3423	3375	3375
q11	640	505	505	505
q12	853	698	649	649
q13	14598	3208	3304	3208
q14	311	308	301	301
q15	538	505	527	505
q16	614	587	593	587
q17	1878	1539	1532	1532
q18	8134	7953	7915	7915
q19	1733	1526	1705	1526
q20	2195	1930	1954	1930
q21	5900	5446	5421	5421
q22	1126	1059	1016	1016
Total cold run time: 71964 ms
Total hot run time: 57200 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194036 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c7a9c7f4b108883c07cb1a4de50b6812308cfb63, data reload: false

query1	1260	905	855	855
query2	6338	1966	1935	1935
query3	10639	3969	3961	3961
query4	59750	26213	23315	23315
query5	5411	514	496	496
query6	397	165	168	165
query7	5779	287	289	287
query8	313	233	246	233
query9	8972	2515	2511	2511
query10	509	283	277	277
query11	17956	15148	15397	15148
query12	149	101	108	101
query13	1566	409	389	389
query14	11219	7671	7250	7250
query15	289	177	172	172
query16	7591	467	440	440
query17	1121	590	553	553
query18	2021	328	294	294
query19	297	154	145	145
query20	119	108	107	107
query21	207	109	110	109
query22	4733	4539	4604	4539
query23	34218	33211	33181	33181
query24	5948	2866	2803	2803
query25	545	404	419	404
query26	702	157	156	156
query27	1788	284	281	281
query28	3686	2083	2076	2076
query29	714	406	415	406
query30	301	149	149	149
query31	933	769	774	769
query32	84	60	61	60
query33	456	285	288	285
query34	867	465	481	465
query35	837	742	721	721
query36	1081	921	938	921
query37	146	87	91	87
query38	3919	3916	3894	3894
query39	1454	1392	1369	1369
query40	193	114	110	110
query41	48	46	45	45
query42	114	96	94	94
query43	515	472	475	472
query44	1080	755	759	755
query45	199	163	168	163
query46	1089	736	741	736
query47	1877	1791	1827	1791
query48	372	315	301	301
query49	790	433	444	433
query50	813	426	417	417
query51	7017	6914	6984	6914
query52	104	87	88	87
query53	255	175	178	175
query54	579	498	464	464
query55	78	77	77	77
query56	288	265	274	265
query57	1212	1055	1071	1055
query58	234	259	239	239
query59	3015	3025	2832	2832
query60	319	281	277	277
query61	124	119	122	119
query62	739	670	647	647
query63	233	188	186	186
query64	2919	755	744	744
query65	3179	3171	3134	3134
query66	699	348	344	344
query67	15405	15269	15392	15269
query68	3081	607	603	603
query69	410	287	292	287
query70	1078	1104	1149	1104
query71	380	285	283	283
query72	6334	4281	4206	4206
query73	740	323	329	323
query74	9309	8921	8842	8842
query75	3371	2670	2733	2670
query76	1573	1004	972	972
query77	552	315	306	306
query78	9895	10557	9693	9693
query79	1410	531	527	527
query80	910	521	522	521
query81	567	235	234	234
query82	305	149	148	148
query83	238	149	146	146
query84	272	76	72	72
query85	704	293	288	288
query86	460	301	279	279
query87	4452	4315	4220	4220
query88	3413	2382	2375	2375
query89	375	282	281	281
query90	1850	187	190	187
query91	128	102	100	100
query92	65	51	48	48
query93	1052	532	528	528
query94	821	296	297	296
query95	341	255	250	250
query96	591	268	274	268
query97	3244	3078	3068	3068
query98	224	207	194	194
query99	1587	1263	1289	1263
Total cold run time: 307536 ms
Total hot run time: 194036 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (9395/25506)
Line Coverage: 28.26% (77438/274033)
Region Coverage: 27.66% (39969/144510)
Branch Coverage: 24.30% (20336/83694)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c7a9c7f4b108883c07cb1a4de50b6812308cfb63_c7a9c7f4b108883c07cb1a4de50b6812308cfb63/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 32.31 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c7a9c7f4b108883c07cb1a4de50b6812308cfb63, data reload: false

query1	0.05	0.04	0.05
query2	0.08	0.04	0.03
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.50	0.49	0.50
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.50	0.49
query10	0.54	0.58	0.55
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.59	0.59
query14	2.00	2.03	2.03
query15	0.83	0.84	0.81
query16	0.37	0.37	0.35
query17	1.03	1.05	1.08
query18	0.22	0.21	0.20
query19	1.93	1.71	1.74
query20	0.02	0.01	0.01
query21	15.38	0.65	0.66
query22	4.17	6.70	2.18
query23	18.35	1.43	1.31
query24	2.17	0.22	0.22
query25	0.15	0.09	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.07
query28	13.17	1.02	1.00
query29	12.62	3.31	3.27
query30	0.24	0.06	0.06
query31	2.87	0.39	0.40
query32	3.27	0.48	0.48
query33	2.96	3.00	3.05
query34	17.04	4.48	4.43
query35	4.42	4.46	4.45
query36	0.67	0.47	0.48
query37	0.17	0.16	0.16
query38	0.16	0.15	0.15
query39	0.05	0.03	0.04
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.72 s
Total hot run time: 32.31 s

HappenLee
HappenLee approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit e444100 into apache:master Sep 10, 2024
23 of 28 checks passed
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@Mryange @dataroaring
[opt](function) Optimize ConvertTz function when using constant param…
a3dd39d 
…eters. (#40366)

mysql [test]>select count(convert_tz(d, 'Asia/Shanghai', 'America/Los_Angeles')), count(convert_tz(dt, 'America/Los_Angeles', '+00:00')) from dates; 
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
| count(convert_tz(cast(d as DATETIMEV2(6)), 'Asia/Shanghai', 'America/Los_Angeles')) | count(convert_tz(dt, 'America/Los_Angeles', '+00:00')) |
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
|                                                                            16000000 |                                               16000000 |
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
1 row in set (13.91 sec)

mysql [test]>select count(convert_tz(d, 'Asia/Shanghai', 'America/Los_Angeles')), count(convert_tz(dt, 'America/Los_Angeles', '+00:00')) from dates;
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
| count(convert_tz(cast(d as DATETIMEV2(6)), 'Asia/Shanghai', 'America/Los_Angeles')) | count(convert_tz(dt, 'America/Los_Angeles', '+00:00')) |
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
|                                                                            16000000 |                                               16000000 |
+-------------------------------------------------------------------------------------+--------------------------------------------------------+
1 row in set (4.59 sec)
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mryange @doris-robot @HappenLee @zhangstar333 @dataroaring