[improvement](mtmv) Support to add use_for_rewrite property when create materialized view #40332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 37811 ms |
TPC-DS: Total hot run time: 192352 ms |
ClickBench: Total hot run time: 32.11 s |
|
is_used_in_rewrite -> use_for_rewrite |
|
run buildall |
TPC-H: Total hot run time: 38457 ms |
TPC-DS: Total hot run time: 192909 ms |
ClickBench: Total hot run time: 32.72 s |
morrySnow
added
kind/docs
morrySnow
changed the title
morrySnow
reviewed
Sep 6, 2024
Comment on lines
148
to
150
| LOG.debug(String.format("mv doesn't part in query rewrite process because " | ||
| + "use_for_rewrite is false, mv is %s", | ||
| materializedView.getName())); |
There was a problem hiding this comment.
avoid use string format, use '{}' in message template to avoid new string object for every log even if not print it
seawinde
force-pushed
the
mv_add_enable_rewrite_field
branch
from
44f9817 to
7e5124b
Compare
|
run buildall |
TPC-H: Total hot run time: 38082 ms |
TPC-DS: Total hot run time: 190022 ms |
ClickBench: Total hot run time: 31.64 s |
zddr
approved these changes
Sep 9, 2024
.../main/java/org/apache/doris/nereids/rules/exploration/mv/InitMaterializationContextHook.java
Outdated
Show resolved
Hide resolved
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 37715 ms |
TPC-DS: Total hot run time: 192962 ms |
ClickBench: Total hot run time: 31.45 s |
|
run buildall |
TPC-H: Total hot run time: 37958 ms |
TPC-DS: Total hot run time: 192217 ms |
ClickBench: Total hot run time: 31.65 s |
zddr
approved these changes
Sep 10, 2024
|
run buildall |
TPC-H: Total hot run time: 38201 ms |
TPC-DS: Total hot run time: 198913 ms |
ClickBench: Total hot run time: 32.07 s |
morrySnow
approved these changes
Sep 11, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Sep 14, 2024
…te materialized view (apache#40332) Add `is_used_in_rewrite` property when create mv. Default true; If `is_used_in_rewrite` is false which means the mv would not partion in query rewrite. Such as mv def is as following: CREATE MATERIALIZED VIEW mv1 BUILD IMMEDIATE REFRESH AUTO ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ( 'replication_num' = '1', 'use_for_rewrite' = 'false' ) AS SELECT k1, k2, count(*) from t1 group by k1, k2; if we run query as following, this mv would not partition in the query rewrite: SELECT k2, count(*) from t1 group by k2;
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
…te materialized view (#40332) Add `is_used_in_rewrite` property when create mv. Default true; If `is_used_in_rewrite` is false which means the mv would not partion in query rewrite. Such as mv def is as following: CREATE MATERIALIZED VIEW mv1 BUILD IMMEDIATE REFRESH AUTO ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ( 'replication_num' = '1', 'use_for_rewrite' = 'false' ) AS SELECT k1, k2, count(*) from t1 group by k1, k2; if we run query as following, this mv would not partition in the query rewrite: SELECT k2, count(*) from t1 group by k2;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add
use_for_rewriteproperty when create mv. Default true;If
use_for_rewriteis false which means the mv would not partion in query rewrite.Such as mv def is as following:
CREATE MATERIALIZED VIEW mv1 BUILD IMMEDIATE REFRESH AUTO ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ( 'replication_num' = '1', 'use_for_rewrite' = 'false' ) AS SELECT k1, k2, count(*) from t1 group by k1, k2;if we run query as following, this mv would not partition in the query rewrite: