Revert "[branch-2.1](hive) support hive write text table (#38549) (#4… #40157
Conversation
… (apache#40063)" This reverts commit c6df7c2.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -88,7 +87,10 @@ Status BlockCompressionCodec::compress(const std::vector<Slice>& inputs, size_t | |||
| } | |||
|
|
|||
| bool BlockCompressionCodec::exceed_max_compress_len(size_t uncompressed_size) { | |||
| return uncompressed_size > std::numeric_limits<int32_t>::max(); | |||
| if (uncompressed_size > std::numeric_limits<int32_t>::max()) { | |||
| return true; | |||
There was a problem hiding this comment.
warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
be/src/util/block_compression.cpp:89:
- if (uncompressed_size > std::numeric_limits<int32_t>::max()) {
- return true;
- }
- return false;
+ return uncompressed_size > std::numeric_limits<int32_t>::max();| @@ -705,7 +661,7 @@ | |||
| static SnappyBlockCompression s_instance; | |||
| return &s_instance; | |||
| } | |||
| ~SnappyBlockCompression() override = default; | |||
| ~SnappyBlockCompression() override {} | |||
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
| ~SnappyBlockCompression() override {} | |
| ~SnappyBlockCompression() override = default; |
| class ZlibBlockCompression : public BlockCompressionCodec { | ||
| public: | ||
| static ZlibBlockCompression* instance() { | ||
| static ZlibBlockCompression s_instance; | ||
| return &s_instance; | ||
| } | ||
| ~ZlibBlockCompression() override = default; | ||
| ~ZlibBlockCompression() {} |
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
| ~ZlibBlockCompression() {} | |
| ~ZlibBlockCompression() = default; |
| class ZlibBlockCompression : public BlockCompressionCodec { | ||
| public: | ||
| static ZlibBlockCompression* instance() { | ||
| static ZlibBlockCompression s_instance; | ||
| return &s_instance; | ||
| } | ||
| ~ZlibBlockCompression() override = default; | ||
| ~ZlibBlockCompression() {} |
There was a problem hiding this comment.
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
| ~ZlibBlockCompression() {} | |
| ~ZlibBlockCompression() override {} |
| @@ -17,7 +17,6 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <gen_cpp/PlanNodes_types.h> | |||
| #include <gen_cpp/parquet_types.h> | |||
There was a problem hiding this comment.
warning: 'gen_cpp/parquet_types.h' file not found [clang-diagnostic-error]
#include <gen_cpp/parquet_types.h>
^| @@ -373,6 +369,11 @@ | |||
| OwnedSlice(uint8_t* _data, size_t size, size_t capacity) | |||
| : _slice(_data, size), _capacity(capacity) {} | |||
|
|
|||
| private: | |||
| // disable copy constructor and copy assignment | |||
| OwnedSlice(const OwnedSlice&) = delete; | |||
There was a problem hiding this comment.
warning: deleted member function should be public [modernize-use-equals-delete]
OwnedSlice(const OwnedSlice&) = delete;
^| private: | ||
| // disable copy constructor and copy assignment | ||
| OwnedSlice(const OwnedSlice&) = delete; | ||
| void operator=(const OwnedSlice&) = delete; |
There was a problem hiding this comment.
warning: deleted member function should be public [modernize-use-equals-delete]
void operator=(const OwnedSlice&) = delete;
^| @@ -18,22 +18,39 @@ | |||
| #include "vec/runtime/vcsv_transformer.h" | |||
|
|
|||
| #include <glog/logging.h> | |||
| #include <stdlib.h> | |||
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers]
| #include <stdlib.h> | |
| #include <cstdlib> |
| @@ -18,22 +18,39 @@ | |||
| #include "vec/runtime/vcsv_transformer.h" | |||
|
|
|||
| #include <glog/logging.h> | |||
| #include <stdlib.h> | |||
| #include <string.h> | |||
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead [modernize-deprecated-headers]
| #include <string.h> | |
| #include <cstring> |
| #include <parquet/file_writer.h> | ||
| #include <parquet/properties.h> | ||
| #include <parquet/types.h> | ||
| #include <stdint.h> |
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead [modernize-deprecated-headers]
| #include <stdint.h> | |
| #include <cstdint> |
…0063)"
This reverts commit c6df7c2.
Proposed changes
Issue Number: close #xxx