-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](nereids) fix union all instance number #39999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run buildall |
run buildall |
morrySnow
reviewed
Aug 28, 2024
morrySnow
approved these changes
Aug 29, 2024
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Aug 29, 2024
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
924060929
approved these changes
Aug 29, 2024
This was referenced Aug 29, 2024
yiguolei
pushed a commit
that referenced
this pull request
Aug 29, 2024
pick from #39999 Co-authored-by: xiongzhongjian <[email protected]>
morrySnow
pushed a commit
that referenced
this pull request
Sep 2, 2024
dataroaring
pushed a commit
that referenced
this pull request
Sep 3, 2024
In following plan pattern, fragment 11 has 3 child fragments aligning with 3 exchange nodes and the union plan node only have 2 plan children, i.e, the aggr node and the exchange node(4). In current union node's parallelism computing, it used the plan children's size to do iteration to find the max parallel but ignore the last fragment's. Actually, it should use fragment's children(exclude unpartitioned ones) instead of plan node's children to do the iteration. 11:VUNION(703) | |----10:VAGGREGATE (update finalize)(697) | | group by: brand_name[#23], skc[#24] | | sortByGroupKey:false | | cardinality=1 | | final projections: '1', brand_name[#25], skc[#26] | | final project output tuple id: 11 | | distribute expr lists: skc[#24] | | | 9:VHASH JOIN(691) | | join op: INNER JOIN(PARTITIONED)[] | | equal join conjunct: (skc[#19] = skc_code[#12]) | | cardinality=1 | | vec output tuple id: 9 | | output tuple id: 9 | | vIntermediate tuple ids: 8 | | hash output slot ids: 18 19 | | final projections: brand_name[#20], skc[#21] | | final project output tuple id: 9 | | distribute expr lists: skc[#19] | | distribute expr lists: skc_code[#12] | | | |----6:VEXCHANGE | | offset: 0 | | distribute expr lists: skc_code[#12] | | | 8:VEXCHANGE | offset: 0 | distribute expr lists: | 4:VEXCHANGE offset: 0 distribute expr lists:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.0.15-merged
dev/2.1.6-merged
dev/3.0.2-merged
reviewed
usercase
Important user case type label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In following plan pattern, fragment 11 has 3 child fragments aligning with 3 exchange nodes and the union plan node only have 2 plan children, i.e, the aggr node and the exchange node(4). In current union node's parallelism computing, it used the plan children's size to do iteration to find the max parallel but ignore the last fragment's. Actually, it should use fragment's children(exclude unpartitioned ones) instead of plan node's children to do the iteration.
11:VUNION(703)
|
|----10:VAGGREGATE (update finalize)(697)
| | group by: brand_name[#23], skc[#24]
| | sortByGroupKey:false
| | cardinality=1
| | final projections: '1', brand_name[#25], skc[#26]
| | final project output tuple id: 11
| | distribute expr lists: skc[#24]
| |
| 9:VHASH JOIN(691)
| | join op: INNER JOIN(PARTITIONED)[]
| | equal join conjunct: (skc[#19] = skc_code[#12])
| | cardinality=1
| | vec output tuple id: 9
| | output tuple id: 9
| | vIntermediate tuple ids: 8
| | hash output slot ids: 18 19
| | final projections: brand_name[#20], skc[#21]
| | final project output tuple id: 9
| | distribute expr lists: skc[#19]
| | distribute expr lists: skc_code[#12]
| |
| |----6:VEXCHANGE
| | offset: 0
| | distribute expr lists: skc_code[#12]
| |
| 8:VEXCHANGE
| offset: 0
| distribute expr lists:
|
4:VEXCHANGE
offset: 0
distribute expr lists: