[opt](query cancel) cancel query if it has pipeline task leakage #39223 #39537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zhiqiang-hhhh
force-pushed
the
pick_39223_to_upstream_branch-2.1
branch
from
fb9c06c to
c78fc0d
Compare
zhiqiang-hhhh
changed the title
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
yiguolei
reviewed
Aug 19, 2024
| @@ -184,6 +185,14 @@ void PipelineFragmentContext::cancel(const PPlanFragmentCancelReason& reason, | |||
| // make result receiver on fe be stocked on rpc forever until timeout... | |||
| // We need a more detail discussion. | |||
| _query_ctx->cancel(msg, Status::Cancelled(msg)); | |||
|
|
|||
| if (reason == PPlanFragmentCancelReason::INTERNAL_ERROR && !msg.empty()) { | |||
There was a problem hiding this comment.
是的，不然事后无法定位问题，也不知道pipeline到底卡在哪里了。
Gabriel39
pushed a commit
that referenced
this pull request
Aug 22, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick #39223 with some modifications. Optimization will only be applied to pipeline x.