Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](group commit) Fix group commit exception in nereids planner #37953

Merged
merged 2 commits into from
Jul 18, 2024
+1 −8
Merged

[Fix](group commit) Fix group commit exception in nereids planner #37953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
099b386
1
Yukang-Lian Jul 16, 2024
b1799c2
2
Yukang-Lian Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,7 +1669,7 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) {
@VariableMgr.VarAttr(name = LOAD_STREAM_PER_NODE)
public int loadStreamPerNode = 2;

@VariableMgr.VarAttr(name = GROUP_COMMIT)
@VariableMgr.VarAttr(name = GROUP_COMMIT, needForward = true)
public String groupCommit = "off_mode";

@VariableMgr.VarAttr(name = INVERTED_INDEX_CONJUNCTION_OPT_THRESHOLD,
Expand Down
7 changes: 0 additions & 7 deletions fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,13 +717,6 @@ private void executeByNereids(TUniqueId queryId) throws Exception {
+ Env.getCurrentEnv().getSelfNode().getHost() + ") and failed to execute"
+ " because Master FE is not ready. You may need to check FE's status"));
}
if (context.getSessionVariable().isEnableInsertGroupCommit()) {
// FIXME: Group commit insert does not need to forward to master
// Nereids does not support group commit, so we can not judge if should forward
// Here throw an exception to fallback to legacy planner and let legacy judge if should forward
// After Nereids support group commit, we can remove this exception
throw new NereidsException(new UserException("Nereids does not support group commit insert"));
}
forwardToMaster();
if (masterOpExecutor != null && masterOpExecutor.getQueryId() != null) {
context.setQueryId(masterOpExecutor.getQueryId());
Expand Down
Loading