-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](Prepared Statment) use fixed charset to init StringLiteral #36860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise in different platform may result incorrect result
run buildall |
TPC-H: Total hot run time: 39758 ms
|
TPC-DS: Total hot run time: 172343 ms
|
ClickBench: Total hot run time: 30.56 s
|
qidaye
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Jun 28, 2024
PR approved by anyone and no changes requested. |
lxr599
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jul 1, 2024
…che#36860) Otherwise in different platform may result incorrect result
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jul 1, 2024
…che#36860) Otherwise in different platform may result incorrect result
eldenmoon
added a commit
that referenced
this pull request
Jul 1, 2024
eldenmoon
added a commit
that referenced
this pull request
Jul 3, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.0.13-merged
dev/2.1.5-merged
dev/3.0.0-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise in different platform may result incorrect result
Proposed changes
Issue Number: close #xxx