Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Prepared Statment) use fixed charset to init StringLiteral #36860

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

eldenmoon
Copy link
Member

Otherwise in different platform may result incorrect result

Proposed changes

Issue Number: close #xxx

Otherwise in different platform may result incorrect result
@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39758 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6967f063916387eaf83ec73f8720310164b649fc, data reload: false

------ Round 1 ----------------------------------
q1	18075	5499	4391	4391
q2	2505	190	200	190
q3	12025	1141	1119	1119
q4	10695	837	811	811
q5	7819	2662	2669	2662
q6	220	133	135	133
q7	947	618	598	598
q8	9561	2042	2040	2040
q9	8937	6458	6465	6458
q10	8862	3669	3712	3669
q11	460	236	232	232
q12	389	229	223	223
q13	17768	2942	2968	2942
q14	273	221	214	214
q15	501	475	458	458
q16	518	370	375	370
q17	947	693	658	658
q18	8027	7484	7494	7484
q19	5019	1406	1460	1406
q20	638	318	312	312
q21	4897	3053	3251	3053
q22	380	336	335	335
Total cold run time: 119463 ms
Total hot run time: 39758 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4338	4208	4213	4208
q2	383	266	259	259
q3	2961	2692	2712	2692
q4	1846	1554	1618	1554
q5	5246	5219	5199	5199
q6	214	126	128	126
q7	2080	1730	1721	1721
q8	3193	3344	3315	3315
q9	8298	8299	8325	8299
q10	3823	3653	3648	3648
q11	596	507	485	485
q12	778	602	595	595
q13	17305	2995	2956	2956
q14	277	272	253	253
q15	521	471	481	471
q16	471	405	430	405
q17	1782	1489	1452	1452
q18	7690	7485	7379	7379
q19	1719	1403	1588	1403
q20	1965	1784	1758	1758
q21	4884	4662	4624	4624
q22	616	562	578	562
Total cold run time: 70986 ms
Total hot run time: 53364 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172343 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6967f063916387eaf83ec73f8720310164b649fc, data reload: false

query1	925	387	385	385
query2	6464	2327	2263	2263
query3	6638	198	200	198
query4	22672	17273	17306	17273
query5	4209	473	470	470
query6	250	160	157	157
query7	4590	293	292	292
query8	327	287	275	275
query9	8590	2403	2424	2403
query10	593	308	291	291
query11	10774	10260	10247	10247
query12	130	80	81	80
query13	1633	389	368	368
query14	10254	6204	6171	6171
query15	218	194	184	184
query16	7800	281	264	264
query17	1414	559	528	528
query18	1892	284	277	277
query19	204	154	156	154
query20	87	84	80	80
query21	215	125	127	125
query22	4598	4453	4276	4276
query23	33744	33207	32919	32919
query24	12441	2807	2869	2807
query25	679	384	385	384
query26	1833	152	165	152
query27	3152	311	318	311
query28	7858	2078	2070	2070
query29	1166	617	616	616
query30	293	151	161	151
query31	960	729	760	729
query32	87	53	57	53
query33	785	297	292	292
query34	963	463	478	463
query35	742	644	618	618
query36	1093	910	924	910
query37	295	73	72	72
query38	2891	2732	2745	2732
query39	865	812	801	801
query40	283	129	127	127
query41	60	53	53	53
query42	124	99	101	99
query43	574	553	529	529
query44	1193	728	743	728
query45	190	167	166	166
query46	1069	696	710	696
query47	1890	1798	1779	1779
query48	367	303	307	303
query49	1206	420	412	412
query50	777	396	398	396
query51	6860	6741	6782	6741
query52	105	89	95	89
query53	369	295	287	287
query54	843	462	454	454
query55	78	75	78	75
query56	300	271	281	271
query57	1159	1021	1077	1021
query58	275	245	249	245
query59	3369	3285	3046	3046
query60	309	288	289	288
query61	113	111	110	110
query62	653	461	463	461
query63	434	286	284	284
query64	9873	2211	1708	1708
query65	3155	3114	3113	3113
query66	1361	333	335	333
query67	15484	14894	14787	14787
query68	9557	548	548	548
query69	716	478	377	377
query70	1425	1062	1137	1062
query71	552	274	272	272
query72	9096	5639	5411	5411
query73	2281	329	330	329
query74	5955	5555	5518	5518
query75	6061	2675	2654	2654
query76	5427	966	912	912
query77	784	294	294	294
query78	10437	9920	9989	9920
query79	8580	515	505	505
query80	2120	459	457	457
query81	608	219	220	219
query82	263	101	101	101
query83	304	163	165	163
query84	269	84	85	84
query85	934	269	266	266
query86	357	274	305	274
query87	3342	3059	3194	3059
query88	4077	2471	2440	2440
query89	489	368	370	368
query90	1966	193	188	188
query91	128	98	99	98
query92	60	47	50	47
query93	4956	505	500	500
query94	1331	190	187	187
query95	407	305	317	305
query96	618	274	273	273
query97	3227	3033	3076	3033
query98	213	200	189	189
query99	1096	852	848	848
Total cold run time: 304433 ms
Total hot run time: 172343 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6967f063916387eaf83ec73f8720310164b649fc, data reload: false

query1	0.04	0.04	0.02
query2	0.08	0.04	0.04
query3	0.22	0.04	0.04
query4	1.69	0.07	0.07
query5	0.50	0.50	0.49
query6	1.13	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.48
query10	0.54	0.54	0.54
query11	0.14	0.11	0.11
query12	0.15	0.12	0.11
query13	0.59	0.59	0.59
query14	0.76	0.78	0.79
query15	0.83	0.81	0.80
query16	0.36	0.37	0.35
query17	1.01	1.03	0.94
query18	0.21	0.27	0.21
query19	1.74	1.68	1.69
query20	0.02	0.01	0.01
query21	15.44	0.66	0.66
query22	4.05	7.68	2.08
query23	18.30	1.38	1.28
query24	2.09	0.24	0.22
query25	0.15	0.09	0.08
query26	0.27	0.17	0.18
query27	0.07	0.09	0.08
query28	13.21	1.01	0.98
query29	12.62	3.35	3.30
query30	0.26	0.06	0.05
query31	2.89	0.39	0.39
query32	3.26	0.47	0.48
query33	2.93	2.90	2.89
query34	17.07	4.39	4.39
query35	4.55	4.50	4.44
query36	0.65	0.47	0.48
query37	0.19	0.15	0.15
query38	0.17	0.13	0.14
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.10	0.05	0.05
query42	0.06	0.04	0.06
query43	0.04	0.05	0.04
Total cold run time: 109.2 s
Total hot run time: 30.56 s

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 28, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@lxr599 lxr599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit d7b5411 into apache:master Jun 28, 2024
27 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Jun 28, 2024
)

Otherwise in different platform may result incorrect result
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jul 1, 2024
…che#36860)

Otherwise in different platform may result incorrect result
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jul 1, 2024
…che#36860)

Otherwise in different platform may result incorrect result
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants