Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](statistics)Fix batch is null bug. #36398

Merged
merged 1 commit into from
Jun 17, 2024
Merged

[fix](statistics)Fix batch is null bug. #36398

merged 1 commit into from
Jun 17, 2024

Conversation

Jibing-Li
Copy link
Contributor

This PR changed result sink logic: #36053
Need to change the show column stats get row batch logic to avoid NPE.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Jibing-Li Jibing-Li marked this pull request as ready for review June 17, 2024 09:57
@Jibing-Li
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40043 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c59475146c9055500a46819e131681c21ca2011f, data reload: false

------ Round 1 ----------------------------------
q1	18214	4497	4596	4497
q2	2022	193	199	193
q3	10475	1088	1024	1024
q4	10191	746	838	746
q5	7482	2714	2580	2580
q6	228	136	133	133
q7	950	609	605	605
q8	9224	2092	2067	2067
q9	8978	6494	6511	6494
q10	8853	3745	3706	3706
q11	456	230	233	230
q12	404	240	227	227
q13	17845	2982	2973	2973
q14	288	230	225	225
q15	530	489	490	489
q16	501	383	385	383
q17	979	658	682	658
q18	7984	7450	7396	7396
q19	1689	1518	1478	1478
q20	679	327	326	326
q21	4924	3830	3262	3262
q22	394	351	361	351
Total cold run time: 113290 ms
Total hot run time: 40043 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4294	4267	4515	4267
q2	359	271	274	271
q3	3027	2730	2743	2730
q4	1888	1633	1600	1600
q5	5284	5309	5282	5282
q6	217	125	127	125
q7	2132	1764	1699	1699
q8	3220	3358	3330	3330
q9	8378	8352	8394	8352
q10	3869	3644	3674	3644
q11	574	511	482	482
q12	776	594	594	594
q13	17420	2980	2972	2972
q14	291	257	268	257
q15	521	492	478	478
q16	476	420	418	418
q17	1769	1504	1461	1461
q18	7501	7431	7346	7346
q19	2562	1593	1488	1488
q20	1984	1771	1771	1771
q21	4803	4716	4699	4699
q22	635	560	526	526
Total cold run time: 71980 ms
Total hot run time: 53792 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171161 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c59475146c9055500a46819e131681c21ca2011f, data reload: false

query1	917	394	364	364
query2	6460	2477	2287	2287
query3	6653	205	205	205
query4	19694	17325	17071	17071
query5	4150	466	448	448
query6	240	169	168	168
query7	4592	301	291	291
query8	332	302	290	290
query9	8521	2388	2341	2341
query10	603	295	283	283
query11	10441	9856	10055	9856
query12	140	96	82	82
query13	1646	355	358	355
query14	10072	6797	6617	6617
query15	243	188	184	184
query16	7779	276	265	265
query17	1696	530	515	515
query18	1909	271	268	268
query19	193	156	154	154
query20	90	85	81	81
query21	209	125	127	125
query22	4453	4061	4126	4061
query23	33756	33003	32946	32946
query24	12206	2937	2871	2871
query25	661	361	355	355
query26	1760	152	151	151
query27	3064	315	311	311
query28	7690	2066	2034	2034
query29	1098	633	614	614
query30	284	153	159	153
query31	954	750	762	750
query32	91	54	55	54
query33	788	269	274	269
query34	991	470	463	463
query35	728	602	626	602
query36	1081	938	920	920
query37	291	70	69	69
query38	2889	2716	2693	2693
query39	845	779	786	779
query40	288	127	122	122
query41	55	54	53	53
query42	116	99	99	99
query43	584	546	523	523
query44	1221	714	721	714
query45	197	166	164	164
query46	1081	697	717	697
query47	1847	1768	1758	1758
query48	368	299	296	296
query49	1184	406	401	401
query50	752	390	374	374
query51	6824	6727	6675	6675
query52	106	95	93	93
query53	357	284	285	284
query54	984	474	432	432
query55	74	72	74	72
query56	271	255	267	255
query57	1139	1060	1027	1027
query58	251	244	264	244
query59	3444	3386	3196	3196
query60	297	270	259	259
query61	109	93	93	93
query62	661	444	447	444
query63	326	294	295	294
query64	9898	2244	1741	1741
query65	3187	3089	3125	3089
query66	1370	324	355	324
query67	15563	14953	14951	14951
query68	4521	530	536	530
query69	450	301	299	299
query70	1117	1099	1104	1099
query71	392	275	277	275
query72	7023	4889	5899	4889
query73	750	326	321	321
query74	5933	5604	5431	5431
query75	3332	2689	2683	2683
query76	2331	918	939	918
query77	447	306	292	292
query78	10283	10054	9831	9831
query79	2732	509	508	508
query80	1142	457	448	448
query81	583	226	222	222
query82	1031	107	104	104
query83	233	170	169	169
query84	241	89	83	83
query85	1296	273	267	267
query86	460	306	330	306
query87	3278	3100	3072	3072
query88	4085	2359	2420	2359
query89	472	388	392	388
query90	1752	193	194	193
query91	127	99	99	99
query92	65	50	47	47
query93	1856	507	489	489
query94	1248	191	181	181
query95	396	306	313	306
query96	589	268	261	261
query97	3251	3054	3057	3054
query98	228	198	192	192
query99	1268	829	826	826
Total cold run time: 275676 ms
Total hot run time: 171161 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.08 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c59475146c9055500a46819e131681c21ca2011f, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.07
query5	0.51	0.47	0.49
query6	1.13	0.71	0.72
query7	0.02	0.01	0.01
query8	0.06	0.05	0.04
query9	0.54	0.50	0.47
query10	0.55	0.54	0.56
query11	0.15	0.11	0.11
query12	0.15	0.13	0.12
query13	0.59	0.58	0.61
query14	0.81	0.78	0.75
query15	0.84	0.80	0.81
query16	0.36	0.37	0.36
query17	0.98	0.93	0.94
query18	0.22	0.24	0.25
query19	1.83	1.71	1.70
query20	0.01	0.02	0.01
query21	15.42	0.66	0.65
query22	4.25	7.23	1.73
query23	18.28	1.36	1.22
query24	2.22	0.22	0.21
query25	0.17	0.08	0.08
query26	0.26	0.19	0.18
query27	0.08	0.07	0.08
query28	13.17	1.00	1.00
query29	12.58	3.33	3.29
query30	0.26	0.06	0.06
query31	2.86	0.38	0.39
query32	3.28	0.46	0.47
query33	2.88	2.87	2.84
query34	17.07	4.42	4.43
query35	4.44	4.46	4.42
query36	0.65	0.46	0.46
query37	0.19	0.15	0.14
query38	0.16	0.15	0.14
query39	0.04	0.03	0.04
query40	0.18	0.14	0.15
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.41 s
Total hot run time: 30.08 s

@Jibing-Li
Copy link
Contributor Author

run feut

morningman
morningman approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jibing-Li Jibing-Li merged commit 7fe006f into apache:master Jun 17, 2024
27 of 30 checks passed
@Jibing-Li Jibing-Li deleted the fixnull branch June 17, 2024 14:26
dataroaring pushed a commit that referenced this pull request Jun 21, 2024
@Jibing-Li @dataroaring
[fix](statistics)Fix batch is null bug. (#36398)
2207270 
This PR changed result sink logic:
#36053
Need to change the show column stats get row batch logic to avoid NPE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.0-merged not-merge/2.1 reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jibing-Li @doris-robot @morningman @morrySnow @dataroaring