-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](plan) only scan node with limit and no predicate can reduce to 1 instance (#31342) #31606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run buildall |
Thank you for your contribution to Apache Doris. |
TPC-H: Total hot run time: 50005 ms
|
TPC-DS: Total hot run time: 202310 ms
|
ClickBench: Total hot run time: 30.71 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
…1 instance (apache#31342) This PR apache#25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory. But this is wrong because we can not guarantee that the predicates can truly help to prune the data. So I modify the logic to remove this opt. Now, only scan node with limit and NO predicate can reduce to only 1 instance.
run buildall |
TPC-H: Total hot run time: 49722 ms
|
TPC-DS: Total hot run time: 202539 ms
|
ClickBench: Total hot run time: 30.5 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…1 instance (apache#31342) (apache#31606) This PR apache#25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory. But this is wrong because we can not guarantee that the predicates can truly help to prune the data. So I modify the logic to remove this opt. Now, only scan node with limit and NO predicate can reduce to only 1 instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bp #31342