Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement](function) optimization for substr with ascii string (#2… #29884

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

…9799)

Proposed changes

pick from #29799

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.42 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17167381001 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8028/21208)
Line Coverage: 29.51% (65306/221280)
Region Coverage: 28.97% (33599/115983)
Branch Coverage: 24.83% (17243/69456)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4cfd34c33fa27594f8d511fa723b9bc5f3b3473d_4cfd34c33fa27594f8d511fa723b9bc5f3b3473d/report/index.html

@xiaokang xiaokang merged commit 68087ec into apache:branch-2.0 Jan 11, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants