Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] (schema change) fix the bug that non light schema change tables can rename column #29871

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

luwei16
Copy link
Contributor

@luwei16 luwei16 commented Jan 11, 2024

No description provided.

@luwei16
Copy link
Contributor Author

luwei16 commented Jan 11, 2024

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 11, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 49695 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 75455b3f946fa96ba3f7ebeab16bd07281954d65, data reload: false

------ Round 1 ----------------------------------
q1	18224	4337	4328	4328
q2	2034	150	145	145
q3	10285	1883	1918	1883
q4	10325	1237	1301	1237
q5	8532	3940	3965	3940
q6	231	125	119	119
q7	1998	1593	1579	1579
q8	9462	2673	2688	2673
q9	13900	10755	10398	10398
q10	8623	3529	3526	3526
q11	411	237	235	235
q12	473	298	293	293
q13	18359	3981	4056	3981
q14	353	320	323	320
q15	511	445	458	445
q16	687	605	579	579
q17	1117	931	958	931
q18	7276	6856	6999	6856
q19	1656	1513	1457	1457
q20	505	319	308	308
q21	4411	4075	4113	4075
q22	506	387	419	387
Total cold run time: 119879 ms
Total hot run time: 49695 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4321	4273	4267	4267
q2	325	227	219	219
q3	4175	4182	4124	4124
q4	2769	2783	2761	2761
q5	7340	7226	7269	7226
q6	232	122	117	117
q7	3266	2933	2876	2876
q8	4345	4481	4486	4481
q9	17215	17186	17589	17186
q10	4447	4469	4448	4448
q11	776	706	690	690
q12	1043	851	857	851
q13	7680	3810	3769	3769
q14	446	433	424	424
q15	505	468	465	465
q16	761	694	706	694
q17	3910	3868	3950	3868
q18	8788	8867	8847	8847
q19	1687	1698	1622	1622
q20	2341	2144	2099	2099
q21	8628	8636	8493	8493
q22	1117	1006	951	951
Total cold run time: 86117 ms
Total hot run time: 80478 ms

@xiaokang
Copy link
Contributor

#29850

@doris-robot
Copy link

TPC-DS: Total hot run time: 239340 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 75455b3f946fa96ba3f7ebeab16bd07281954d65, data reload: false

query1	924	392	383	383
query2	6514	2156	2018	2018
query3	6823	204	209	204
query4	20908	18071	18252	18071
query5	19736	6287	6287	6287
query6	301	232	223	223
query7	4178	299	302	299
query8	281	268	238	238
query9	3020	2624	2560	2560
query10	389	281	274	274
query11	11494	10955	10911	10911
query12	128	78	77	77
query13	5614	602	584	584
query14	17737	13202	13253	13202
query15	358	235	242	235
query16	5708	274	272	272
query17	3169	888	890	888
query18	2271	404	399	399
query19	216	149	150	149
query20	72	78	81	78
query21	189	92	94	92
query22	5356	5152	5218	5152
query23	32900	32156	32403	32156
query24	6908	6506	6469	6469
query25	520	434	427	427
query26	553	167	160	160
query27	1899	310	302	302
query28	6020	2213	2194	2194
query29	676	392	393	392
query30	234	157	157	157
query31	910	730	740	730
query32	64	56	60	56
query33	431	275	284	275
query34	927	488	484	484
query35	1102	891	934	891
query36	1618	1486	1454	1454
query37	85	61	60	60
query38	3062	2909	2932	2909
query39	1366	1328	1318	1318
query40	196	86	103	86
query41	36	31	31	31
query42	87	83	81	81
query43	659	616	634	616
query44	1293	709	710	709
query45	249	236	235	235
query46	1236	982	959	959
query47	1833	1702	2032	1702
query48	962	663	641	641
query49	603	375	359	359
query50	891	680	684	680
query51	5625	5544	5601	5544
query52	85	71	72	71
query53	441	345	332	332
query54	2428	2283	2281	2281
query55	80	82	81	81
query56	238	219	223	219
query57	1204	1119	1116	1116
query58	219	187	178	178
query59	3541	3254	3181	3181
query60	244	240	236	236
query61	90	86	98	86
query62	910	559	590	559
query63	482	351	348	348
query64	2173	1442	1464	1442
query65	3751	3668	3666	3666
query66	969	380	367	367
query67	15581	16265	15908	15908
query68	8685	644	671	644
query69	518	262	268	262
query70	1781	1926	1974	1926
query71	382	297	319	297
query72	4455	3371	3316	3316
query73	709	318	314	314
query74	6266	5968	5908	5908
query75	4546	3496	3455	3455
query76	5633	1218	1219	1218
query77	840	250	251	250
query78	32991	49753	52359	49753
query79	16184	667	624	624
query80	4987	440	429	429
query81	575	230	233	230
query82	868	106	99	99
query83	401	142	145	142
query84	267	72	73	72
query85	2577	296	280	280
query86	483	382	378	378
query87	3246	2998	3012	2998
query88	6928	2317	2310	2310
query89	446	257	266	257
query90	2524	215	212	212
query91	159	122	140	122
query92	64	50	51	50
query93	6055	666	624	624
query94	1408	182	178	178
query95	530	513	494	494
query96	653	326	329	326
query97	6458	6390	6367	6367
query98	185	161	168	161
query99	3939	979	900	900
Total cold run time: 346510 ms
Total hot run time: 239340 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.44 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 75455b3f946fa96ba3f7ebeab16bd07281954d65, data reload: false

query1	0.03	0.02	0.02
query2	0.07	0.02	0.02
query3	0.25	0.05	0.04
query4	1.80	0.07	0.06
query5	0.54	0.52	0.52
query6	1.24	0.62	0.61
query7	0.02	0.01	0.01
query8	0.05	0.02	0.02
query9	0.52	0.49	0.49
query10	0.54	0.54	0.53
query11	0.12	0.09	0.08
query12	0.12	0.09	0.09
query13	0.62	0.61	0.61
query14	0.77	0.79	0.80
query15	0.80	0.76	0.76
query16	0.37	0.39	0.37
query17	1.00	1.02	1.03
query18	0.21	0.29	0.23
query19	1.94	1.86	1.86
query20	0.01	0.01	0.00
query21	15.46	0.56	0.56
query22	2.26	2.23	1.83
query23	17.58	1.02	0.85
query24	5.42	6.25	1.44
query25	2.54	0.16	0.13
query26	0.14	0.14	0.14
query27	0.13	0.16	0.14
query28	4.81	0.74	0.74
query29	12.78	2.36	2.16
query30	0.57	0.59	0.52
query31	2.81	0.39	0.36
query32	3.41	0.51	0.48
query33	3.09	3.05	3.04
query34	15.26	4.82	4.80
query35	4.86	4.85	4.86
query36	1.04	1.01	1.03
query37	0.06	0.04	0.05
query38	0.03	0.03	0.02
query39	0.01	0.02	0.02
query40	0.15	0.14	0.14
query41	0.06	0.02	0.02
query42	0.02	0.01	0.01
query43	0.02	0.02	0.01
Total cold run time: 103.53 s
Total hot run time: 31.44 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 75455b3f946fa96ba3f7ebeab16bd07281954d65 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.6 seconds inserted 10000000 Rows, about 462K ops/s

@dataroaring dataroaring merged commit 6643e90 into apache:branch-2.0 Jan 11, 2024
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants