Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](http)(cherry-pick)fix exception when querying map data through http #29827

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

gnehil
Copy link
Contributor

@gnehil gnehil commented Jan 11, 2024

Proposed changes

Issue Number: close #xxx

pick from #29686

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@gnehil gnehil marked this pull request as ready for review January 11, 2024 02:04
@xiaokang
Copy link
Contributor

run buildall

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 11, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 49830 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 209be7db0e8796a435a0cd6dccce9549a64d71a8, data reload: false

------ Round 1 ----------------------------------
q1	17926	4385	4371	4371
q2	2023	152	149	149
q3	10275	1872	1914	1872
q4	10363	1256	1333	1256
q5	8455	3976	3913	3913
q6	229	124	124	124
q7	1993	1599	1619	1599
q8	9528	2717	2719	2717
q9	13387	10466	10401	10401
q10	8659	3534	3485	3485
q11	405	234	243	234
q12	472	297	302	297
q13	18332	3970	4034	3970
q14	361	327	330	327
q15	500	462	455	455
q16	703	589	582	582
q17	1125	976	910	910
q18	7137	6904	6990	6904
q19	1702	1594	1544	1544
q20	496	318	297	297
q21	4465	4089	4016	4016
q22	510	407	408	407
Total cold run time: 119046 ms
Total hot run time: 49830 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4342	4291	4318	4291
q2	319	218	227	218
q3	4194	4147	4144	4144
q4	2767	2742	2736	2736
q5	7239	7129	7159	7129
q6	234	119	116	116
q7	3208	2852	2797	2797
q8	4352	4449	4518	4449
q9	17127	16981	17010	16981
q10	4253	4286	4306	4286
q11	762	698	697	697
q12	1037	848	874	848
q13	6726	3770	3748	3748
q14	460	423	422	422
q15	504	455	468	455
q16	761	709	711	709
q17	3839	3877	3965	3877
q18	8978	8806	8795	8795
q19	1732	1701	1695	1695
q20	2396	2165	2170	2165
q21	8575	8875	8882	8875
q22	1114	1072	1063	1063
Total cold run time: 84919 ms
Total hot run time: 80496 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 232343 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 209be7db0e8796a435a0cd6dccce9549a64d71a8, data reload: false

query1	2137	403	398	398
query2	7832	2296	1955	1955
query3	6814	212	205	205
query4	19746	17909	17917	17909
query5	19713	6330	6274	6274
query6	358	231	235	231
query7	4594	305	316	305
query8	265	263	239	239
query9	3028	2621	2577	2577
query10	393	285	279	279
query11	11396	10670	10716	10670
query12	125	78	75	75
query13	5613	598	578	578
query14	18497	13321	13379	13321
query15	363	237	234	234
query16	5686	270	280	270
query17	3110	912	896	896
query18	2276	402	388	388
query19	222	156	158	156
query20	76	77	83	77
query21	185	93	95	93
query22	5303	5159	5105	5105
query23	33235	32599	32499	32499
query24	6871	6582	6524	6524
query25	527	452	441	441
query26	555	163	166	163
query27	1845	309	312	309
query28	5951	2224	2171	2171
query29	665	388	383	383
query30	243	161	159	159
query31	930	714	729	714
query32	63	57	59	57
query33	424	269	277	269
query34	899	467	465	465
query35	1136	904	875	875
query36	1542	1520	1414	1414
query37	92	64	62	62
query38	3109	2935	2885	2885
query39	1365	1314	1319	1314
query40	193	96	98	96
query41	34	32	31	31
query42	89	93	89	89
query43	638	647	690	647
query44	1212	714	718	714
query45	247	239	234	234
query46	1248	954	970	954
query47	1821	1864	1776	1776
query48	963	660	664	660
query49	610	357	368	357
query50	897	646	670	646
query51	5638	5629	5550	5550
query52	80	81	74	74
query53	456	340	328	328
query54	2441	2273	2250	2250
query55	81	72	72	72
query56	222	228	218	218
query57	1196	1130	1109	1109
query58	212	196	190	190
query59	3496	3082	3326	3082
query60	255	224	236	224
query61	88	84	85	84
query62	857	532	556	532
query63	479	345	351	345
query64	2165	1378	1458	1378
query65	3712	3649	3640	3640
query66	951	384	367	367
query67	18322	17562	16073	16073
query68	5842	648	660	648
query69	505	274	279	274
query70	1968	1718	1746	1718
query71	395	310	321	310
query72	4290	3368	3361	3361
query73	729	320	317	317
query74	6342	5921	5792	5792
query75	4220	3564	3634	3564
query76	3793	1150	1149	1149
query77	541	259	247	247
query78	30993	51346	43010	43010
query79	16337	622	644	622
query80	4937	441	430	430
query81	567	235	231	231
query82	985	101	93	93
query83	416	146	132	132
query84	267	74	74	74
query85	2585	310	284	284
query86	485	376	385	376
query87	3278	3031	2982	2982
query88	6596	2342	2331	2331
query89	432	279	313	279
query90	2510	218	208	208
query91	168	130	133	130
query92	65	51	52	51
query93	5495	647	591	591
query94	1410	190	193	190
query95	539	502	494	494
query96	656	332	316	316
query97	6541	6352	6467	6352
query98	188	174	176	174
query99	3965	954	1019	954
Total cold run time: 343827 ms
Total hot run time: 232343 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.22 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 30.1 seconds inserted 10000000 Rows, about 332K ops/s
storage size: 17164153749 Bytes

@doris-robot
Copy link

ClickBench: Total hot run time: 30.42 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 209be7db0e8796a435a0cd6dccce9549a64d71a8, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.02	0.02
query3	0.25	0.05	0.05
query4	1.80	0.07	0.06
query5	0.53	0.53	0.52
query6	1.27	0.61	0.62
query7	0.01	0.01	0.01
query8	0.04	0.02	0.02
query9	0.53	0.50	0.48
query10	0.53	0.53	0.54
query11	0.12	0.09	0.09
query12	0.11	0.09	0.09
query13	0.62	0.61	0.61
query14	0.79	0.78	0.80
query15	0.79	0.75	0.77
query16	0.36	0.36	0.37
query17	1.04	1.02	1.02
query18	0.24	0.25	0.24
query19	1.86	1.84	1.89
query20	0.02	0.01	0.01
query21	15.45	0.56	0.55
query22	2.21	2.48	1.49
query23	17.16	1.11	0.85
query24	9.29	1.12	0.93
query25	2.36	0.15	0.13
query26	0.15	0.13	0.14
query27	0.14	0.16	0.14
query28	4.48	0.75	0.72
query29	12.61	2.36	2.13
query30	0.62	0.53	0.48
query31	2.81	0.38	0.38
query32	3.39	0.48	0.49
query33	3.05	3.06	3.04
query34	15.28	4.78	4.80
query35	4.83	4.85	4.84
query36	1.08	1.01	1.00
query37	0.06	0.05	0.04
query38	0.03	0.02	0.02
query39	0.01	0.01	0.01
query40	0.16	0.13	0.14
query41	0.07	0.01	0.02
query42	0.03	0.02	0.02
query43	0.02	0.01	0.02
Total cold run time: 106.29 s
Total hot run time: 30.42 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 209be7db0e8796a435a0cd6dccce9549a64d71a8 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

@JNSimba JNSimba merged commit f3f1c4b into apache:branch-2.0 Jan 11, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants