Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](inverted index) fix compound directory flush buffer error #28191

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

airborne12
Copy link
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@airborne12
Copy link
Member Author

run buildall

Copy link
Contributor

github-actions bot commented Dec 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.77 seconds
stream load tsv: 586 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17212267199 Bytes

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit bdc9f2e1b86b9ea1e5482460afa04ef9e4da0bb3, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4671	4430	4479	4430
q2	359	161	159	159
q3	1432	1228	1204	1204
q4	1094	889	889	889
q5	3091	3119	3136	3119
q6	255	125	125	125
q7	967	482	478	478
q8	2183	2251	2156	2156
q9	6648	6623	6646	6623
q10	3199	3249	3235	3235
q11	331	195	202	195
q12	349	202	205	202
q13	4533	3800	3795	3795
q14	244	207	216	207
q15	565	521	517	517
q16	443	398	381	381
q17	986	569	542	542
q18	7464	7052	6898	6898
q19	1517	1373	1424	1373
q20	631	323	328	323
q21	3018	2612	2613	2612
q22	344	279	286	279
Total cold run time: 44324 ms
Total hot run time: 39742 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4416	4411	4366	4366
q2	265	159	169	159
q3	3519	3508	3501	3501
q4	2370	2353	2355	2353
q5	5717	5714	5703	5703
q6	238	122	121	121
q7	2390	1839	1854	1839
q8	3478	3477	3480	3477
q9	8949	8977	8956	8956
q10	3889	3976	3984	3976
q11	504	371	394	371
q12	769	604	586	586
q13	4310	3554	3555	3554
q14	286	250	251	250
q15	573	526	524	524
q16	511	463	454	454
q17	1861	1823	1831	1823
q18	8634	8194	8257	8194
q19	1738	1711	1717	1711
q20	2264	1949	1939	1939
q21	6473	6166	6129	6129
q22	493	429	425	425
Total cold run time: 63647 ms
Total hot run time: 60411 ms

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 055b388 into apache:master Dec 8, 2023
17 of 20 checks passed
@xiaokang xiaokang mentioned this pull request Dec 11, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Dec 18, 2023
eldenmoon added a commit that referenced this pull request Dec 18, 2023
* change version to 2.0.3-rc05-var06

* [hotfix](jdbc catalog) fix jdbcmysqlclient npe (#28022)

* [Fix](schema change) disable convert light schema change (#28205)

* [Fix](inverted index) fix compound directory flush buffer error (#28191)

* [Fix](inverted index) fix need read data optimize problem (#28104)

---------

Co-authored-by: zy-kkk <[email protected]>
Co-authored-by: Luwei <[email protected]>
Co-authored-by: airborne12 <[email protected]>
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants