[fix](Nereids) fill miss slot in having subquery #27177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keanji-x
changed the title
|
run buildall |
keanji-x
changed the title
|
add case in desc |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
keanji-x
force-pushed
the
fill_miss_apply_slots
branch
3 times, most recently
from
c0b88aa to
2bdedeb
Compare
|
run buildall |
morrySnow
reviewed
Nov 17, 2023
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/SubqueryToApply.java
Outdated
Show resolved
Hide resolved
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
keanji-x
force-pushed
the
fill_miss_apply_slots
branch
from
2bdedeb to
c83f6bb
Compare
keanji-x
force-pushed
the
fill_miss_apply_slots
branch
from
c83f6bb to
55e235a
Compare
|
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
starocean999
approved these changes
Nov 20, 2023
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
jackwener
approved these changes
Nov 21, 2023
keanji-x
added a commit
to keanji-x/doris
that referenced
this pull request
Nov 22, 2023
fill miss slot in having subquery. such as ``` select * from t group by k having max(k) in (select k from t2) ``` the max(k) should be push down aggregate
keanji-x
added a commit
to keanji-x/doris
that referenced
this pull request
Nov 23, 2023
fill miss slot in having subquery. such as ``` select * from t group by k having max(k) in (select k from t2) ``` the max(k) should be push down aggregate
xiaokang
pushed a commit
that referenced
this pull request
Nov 23, 2023
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Nov 27, 2023
eldenmoon
added a commit
that referenced
this pull request
Nov 27, 2023
* [fix](stats) Fix update rows for unique table didn't get updated properly #26968 (#27337) * [FIX](jsonb) fix jsonb in predict column #27325 (#27424) * [fix](fe) slots in having clause should be set to need materialized(#27412) (#27429) * [Bug](insert)fix insert wrong data on mv when stmt have multiple values (#27297) (#27382) fix insert wrong data on mv when stmt have multiple values * [fix](fe ut) Fix OlapQueryCacheTest failed (#27305) (#27406) 1. ``` java.lang.NullPointerException: null at org.apache.doris.catalog.Env.getCurrentSystemInfo(Env.java:793) ~[classes/:?] at org.apache.doris.qe.SimpleScheduler$UpdateBlacklistThread.run(SimpleScheduler.java:206) ~[classes/:?] at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_382] java.lang.NullPointerException at org.apache.doris.qe.OlapQueryCacheTest.setUp(OlapQueryCacheTest.java:226) ``` 2. ``` [ERROR] testSqlCacheKeyWithNestedViewForNereids Time elapsed: 1.962 s <<< FAILURE! java.lang.AssertionError: SELECT command denied to user 'testCluster:testUser'@'192.168.1.1' for table 'internal: testCluster:testDb: appevent' at org.apache.doris.qe.OlapQueryCacheTest.parseSqlByNereids(OlapQueryCacheTest.java:579) at org.apache.doris.qe.OlapQueryCacheTest.testSqlCacheKeyWithNestedViewForNereids(OlapQueryCacheTest.java:1338) ``` 3. ``` [ERROR] Tests run: 28, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 113.63 s <<< FAILURE! - in org.apache.doris.qe.OlapQueryCacheTest [ERROR] testCacheModeTable Time elapsed: 1.657 s <<< ERROR! java.lang.IllegalArgumentException: Value of type org.apache.doris.qe.QueryState incompatible with return type org.apache.doris.system.SystemInfoService of org.apache.doris.catalog.Env#getCurrentSystemInfo() at org.apache.doris.qe.OlapQueryCacheTest.setUp(OlapQueryCacheTest.java:156) ``` * [regression test](schema change) add some schema change regression cases (#27112) (#27418) * [fix](Nereids) result type of add precision is 1 more than expected (#27136) (#27426) * [fix](Nereids): fill miss slot in having subquery (#27177) (#27394) * [fix](memory) Fix make_top_consumption_snapshots heap-use-after-free #27434 (#27465) * [fix](function) make TIMESTAMP function DEPEND_ON_ARGUMENT (#27343) (#27458) * [fix](test) order by clause in test_map(#27390) (#27391) pick #27390 * [performance](Planner): optimize getStringValue() in DateLiteral (#27363) (#27470) - reduce cost of `getStringValue()` - original code don't consider `microsecond` part in `getStringValue()` (cherry picked from commit 044a295) * [Chore](pick) do not push down agg on aggregate column (#27356) (#27498) * [fix](stats) table not exists error msg not print objects name #27074 (#27463) * [improve](nereids) support agg function of count(const value) pushdown #26677 (#27499) support sql: select count(1)-count(not null) from table, the agg of count could push down. * [test](fe-ut) fix unstable MysqlServerTest (#27459) Need to find a unbind port for MysqlServerTest * [opt](MergedIO) no need to merge large columns (#27315) (#27497) 1. Fix a profile bug of `MergeRangeFileReader`, and add a profile `ApplyBytes` to show the total bytes of ranges. 2. There's no need to merge large columns, because `MergeRangeFileReader` will increase the copy time. * [improvement](drop tablet) impr gc shutdown tablet lock (#26151) (#27478) * [doc](stats) SQL manual for stats (#27461) * [chore](merge-on-write) disable rowid conversion check for mow table by default (#27482) (#27508) * [fix](regression)Fix hive p2 case (#27466) (#27511) * [fix](statistics)Fix auto analyze remove finished job bug #27486 (#27510) * [Bug](bitmap) Fix heap-use-after-free in the bitmap functions #27411 (#27521) * [Pick](nereids) Pick: partition prune fails in case of NOT expression (#27047) (#27507) * [fix](clone) Fix engine_clone file exist (#27361) (#27536) * [chore](case) adjust timeout of broker load case #27540 * Fix auto analyze doesn't filter unsupported type bug. (#27547) Fix auto analyze doesn't filter unsupported type bug. Catch throwable in auto analyze thread for each database, otherwise the thread will quit when one database failed to create jobs and all other databases will not get analyzed. change FE config item full_auto_analyze_simultaneously_running_task_num to auto_analyze_simultaneously_running_task_num backport #27559 * [chore](fe plugin) Upgrade dependency to doris 2.0-SNAPSHOT #27522 (#27558) * [Bug](materialized-view) add limitation for duplicate expr on materialized view (#27523) (#27562) * [fix](planner)join node should output required slot from parent node #27526 (#27551) * [branch-2.0](hive) enable hive view by default (#27550) * [pick](nereids) adjust bc join and shuffle join #27113 (#27566) * [Fix](hive-transactional-table) Fix NPE when query empty hive transactional table. (#27567) --------- Co-authored-by: AKIRA <[email protected]> Co-authored-by: amory <[email protected]> Co-authored-by: Jerry Hu <[email protected]> Co-authored-by: Pxl <[email protected]> Co-authored-by: Xinyi Zou <[email protected]> Co-authored-by: Luwei <[email protected]> Co-authored-by: morrySnow <[email protected]> Co-authored-by: 谢健 <[email protected]> Co-authored-by: Mryange <[email protected]> Co-authored-by: jakevin <[email protected]> Co-authored-by: zhangstar333 <[email protected]> Co-authored-by: Mingyu Chen <[email protected]> Co-authored-by: Ashin Gau <[email protected]> Co-authored-by: yujun <[email protected]> Co-authored-by: Xin Liao <[email protected]> Co-authored-by: Jibing-Li <[email protected]> Co-authored-by: xy720 <[email protected]> Co-authored-by: minghong <[email protected]> Co-authored-by: Jack Drogon <[email protected]> Co-authored-by: Dongyang Li <[email protected]> Co-authored-by: zhiqiang <[email protected]> Co-authored-by: starocean999 <[email protected]> Co-authored-by: Qi Chen <[email protected]>
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Nov 28, 2023
fill miss slot in having subquery. such as ``` select * from t group by k having max(k) in (select k from t2) ``` the max(k) should be push down aggregate
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Dec 4, 2023
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
fill miss slot in having subquery. such as ``` select * from t group by k having max(k) in (select k from t2) ``` the max(k) should be push down aggregate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fill miss slot in having subquery
such as
the max(k) should be push down aggregate
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...