Revert "[improvement](scanner_schedule) reduce memory consumption of … #26772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scanner (apache#24199)" This reverts commit 71dcb58.
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -74,13 +74,13 @@ class ScannerContext { | |||
| ScannerContext(RuntimeState* state_, VScanNode* parent, | |||
| const TupleDescriptor* output_tuple_desc, | |||
| const std::list<VScannerSPtr>& scanners_, int64_t limit_, | |||
| int64_t max_bytes_in_blocks_queue_, const int num_parallel_instances = 1, | |||
| int64_t max_bytes_in_blocks_queue_, const int num_parallel_instances = 0, | |||
There was a problem hiding this comment.
warning: parameter 'num_parallel_instances' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
| int64_t max_bytes_in_blocks_queue_, const int num_parallel_instances = 0, | |
| int64_t max_bytes_in_blocks_queue_, int num_parallel_instances = 0, |
| } | ||
|
|
||
| int get_available_thread_slot_num() { | ||
| int cal_thread_slot_num_by_free_block_num() { |
There was a problem hiding this comment.
warning: method 'cal_thread_slot_num_by_free_block_num' can be made static [readability-convert-member-functions-to-static]
Suggested change
| int cal_thread_slot_num_by_free_block_num() { | |
| static int cal_thread_slot_num_by_free_block_num() { |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…scanner (#24199)"
This reverts commit 71dcb58.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...