Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](inverted index) fix compound query result error when disable inverted_index_query session variable #26327

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

airborne12
Copy link
Member

Proposed changes

Issue Number: close #xxx

when we disable session variable:

set enable_inverted_index_query=false; 

we got wrong result for query like this:

select COUNT() from wc_httplogs where request = "images"  or (size = 0 and status > 400);

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

github-actions bot commented Nov 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@airborne12
Copy link
Member Author

run buildall

Copy link
Contributor

github-actions bot commented Nov 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.37% (8481/22693)
Line Coverage: 29.73% (68596/230721)
Region Coverage: 28.39% (35500/125034)
Branch Coverage: 25.12% (18117/72114)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ade887c618d004bd70bd3d01f94a76b0b650da70_ade887c618d004bd70bd3d01f94a76b0b650da70/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.39 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162265998 Bytes

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 2, 2023

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

PR approved by anyone and no changes requested.

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit 3f47eb5 into apache:master Nov 2, 2023
xiaokang pushed a commit that referenced this pull request Nov 3, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Nov 4, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 8, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged p0_w reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants