Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](fe) add function 'BitmapAgg' in nereids #25508

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[feature](fe) add function 'BitmapAgg' in nereids #25508

merged 1 commit into from
Oct 18, 2023

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Oct 17, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrhhsg
Copy link
Member Author

mrhhsg commented Oct 17, 2023

run buildall

@mrhhsg mrhhsg force-pushed the add_bitmap_agg_nereids branch from a592b1a to 99927fb Compare October 17, 2023 04:08
@mrhhsg
Copy link
Member Author

mrhhsg commented Oct 17, 2023

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.9 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162110553 Bytes

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.06 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161966088 Bytes

yiguolei
yiguolei previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

morrySnow
morrySnow reviewed Oct 17, 2023
View reviewed changes
...e-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/BitmapAgg.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add regression test case for all signatures in regression-test/suites/nereids_function_p0/agg_function/agg.groovy

@mrhhsg mrhhsg force-pushed the add_bitmap_agg_nereids branch from 99927fb to 768f8b6 Compare October 17, 2023 09:13
@mrhhsg mrhhsg force-pushed the add_bitmap_agg_nereids branch from 768f8b6 to 969e165 Compare October 17, 2023 09:16
@mrhhsg
Copy link
Member Author

mrhhsg commented Oct 17, 2023

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.35 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162093509 Bytes

@wm1581066 wm1581066 added dev/2.0.3 usercase Important user case type label labels Oct 17, 2023
yiguolei
yiguolei approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xinyiZzz
xinyiZzz approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 62d0658 into apache:master Oct 18, 2023
xiaokang pushed a commit that referenced this pull request Oct 18, 2023
@mrhhsg @xiaokang
[feature](fe) add function 'BitmapAgg' in nereids (#25508)
51b8eaa
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@mrhhsg
[feature](fe) add function 'BitmapAgg' in nereids (apache#25508)
89f2c84
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Open
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@mrhhsg
[feature](fe) add function 'BitmapAgg' in nereids (apache#25508)
f25ba9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow left review comments

@yiguolei yiguolei yiguolei approved these changes

@xinyiZzz xinyiZzz xinyiZzz approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mrhhsg @doris-robot @yiguolei @xinyiZzz @morrySnow @xiaokang @wm1581066