Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](multi-catalog)fix maxcompute partition filter and session creation #24911

Merged
merged 2 commits into from
Oct 17, 2023
Merged

[fix](multi-catalog)fix maxcompute partition filter and session creation #24911

merged 2 commits into from
Oct 17, 2023

Conversation

wsjz
Copy link
Contributor

@wsjz wsjz commented Sep 26, 2023 •
edited
Loading

Proposed changes

add maxcompute partition support
fix maxcompute partition filter
modify maxcompute session create method

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@wsjz wsjz force-pushed the fix_mc_part_and_session branch 2 times, most recently from 2c1ebc6 to af66655 Compare October 15, 2023 10:15
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@wsjz wsjz force-pushed the fix_mc_part_and_session branch from af66655 to bf26895 Compare October 15, 2023 11:02
@wsjz wsjz marked this pull request as ready for review October 15, 2023 11:03
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@wsjz wsjz force-pushed the fix_mc_part_and_session branch from 6c4bd7f to 38a5773 Compare October 15, 2023 11:19
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

morningman
morningman reviewed Oct 15, 2023
View reviewed changes
...ions/max-compute-scanner/src/main/java/org/apache/doris/maxcompute/MaxComputeJniScanner.java
@@ -124,6 +129,7 @@ protected void initTableInfo(ColumnType[] requiredTypes, String[] requiredFields
}
// reorder columns
List<Column> columnList = curTableScan.getSchema().getColumns();
columnList.addAll(curTableScan.getSchema().getPartitionColumns());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does curTableScan.getSchema().getColumns() contains partition columns?

Copy link
Contributor Author

@wsjz wsjz Oct 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not contains

...ions/max-compute-scanner/src/main/java/org/apache/doris/maxcompute/MaxComputeJniScanner.java
.map(Column::getName)
.collect(Collectors.toSet());
List<Column> maxComputeColumns = new ArrayList<>(readColumns);
maxComputeColumns.removeIf(e -> partitionColumns.contains(e.getName()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove partition columns here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max compute depart the partition columns from common columns

regression-test/suites/external_table_p2/maxcompute/test_external_catalog_maxcompute.groovy Outdated Show resolved Hide resolved
regression-test/suites/external_table_p2/maxcompute/test_external_catalog_maxcompute.groovy Outdated Show resolved Hide resolved
@wsjz wsjz force-pushed the fix_mc_part_and_session branch from 38a5773 to 84b8091 Compare October 16, 2023 07:11
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@wsjz wsjz force-pushed the fix_mc_part_and_session branch from 84b8091 to 15d6b4f Compare October 16, 2023 07:52
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@wsjz wsjz force-pushed the fix_mc_part_and_session branch from 15d6b4f to 7335b80 Compare October 16, 2023 09:20
@wsjz
Copy link
Contributor Author

wsjz commented Oct 16, 2023

run buildall

@wsjz wsjz force-pushed the fix_mc_part_and_session branch from 7335b80 to 294432f Compare October 16, 2023 09:29
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.70% (8230/22424)
Line Coverage: 28.85% (65958/228624)
Region Coverage: 27.55% (34204/124161)
Branch Coverage: 24.26% (17413/71782)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7335b80d9e94da758383965b91e236ae498674e0_7335b80d9e94da758383965b91e236ae498674e0/report/index.html

@wsjz
Copy link
Contributor Author

wsjz commented Oct 16, 2023

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.70% (8230/22424)
Line Coverage: 28.85% (65965/228624)
Region Coverage: 27.56% (34217/124161)
Branch Coverage: 24.27% (17418/71782)
Coverage Report: http://coverage.selectdb-in.cc/coverage/294432fe5af2126cf782cadcbfeebeb3961ef605_294432fe5af2126cf782cadcbfeebeb3961ef605/report/index.html

@wm1581066 wm1581066 added the usercase Important user case type label label Oct 16, 2023
@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.72 seconds
stream load tsv: 550 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162245617 Bytes

morningman
morningman approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman force-pushed the fix_mc_part_and_session branch from 294432f to 166acc2 Compare October 16, 2023 14:59
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@morningman
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.02% (8285/22378)
Line Coverage: 29.06% (66445/228664)
Region Coverage: 27.74% (34477/124265)
Branch Coverage: 24.37% (17518/71886)
Coverage Report: http://coverage.selectdb-in.cc/coverage/166acc2d1fd5c29c151a7272d78b59851062aded_166acc2d1fd5c29c151a7272d78b59851062aded/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.48 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162037094 Bytes

morningman
morningman approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

zhangguoqiang666
zhangguoqiang666 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@zhangguoqiang666 zhangguoqiang666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 18c2a13 into apache:master Oct 17, 2023
xiaokang pushed a commit that referenced this pull request Oct 18, 2023
@wsjz @xiaokang
[fix](multi-catalog)fix maxcompute partition filter and session creat…
6e5082e 
…ion (#24911)

add maxcompute partition support
fix maxcompute partition filter
modify maxcompute session create method
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@wsjz
[fix](multi-catalog)fix maxcompute partition filter and session creat…
9bf687d 
…ion (apache#24911)

add maxcompute partition support
fix maxcompute partition filter
modify maxcompute session create method
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Open
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@wsjz
[fix](multi-catalog)fix maxcompute partition filter and session creat…
0af6901 
…ion (apache#24911)

add maxcompute partition support
fix maxcompute partition filter
modify maxcompute session create method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@zhangguoqiang666 zhangguoqiang666 zhangguoqiang666 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wsjz @doris-robot @morningman @zhangguoqiang666 @xiaokang @wm1581066