Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](planner) ctas should not change any meta of column in source table #24767

Merged
merged 1 commit into from
Sep 22, 2023
Merged

[fix](planner) ctas should not change any meta of column in source table #24767

merged 1 commit into from
Sep 22, 2023

Conversation

morrySnow
Copy link
Contributor

if previous PR #22770. we try to fix incorrect nullable in target table. However we changed nullable info of column in source table unexpectly

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
[fix](planner) ctas should not change any meta of column in source table
f6824a2 
if previous PR apache#22770. we try to fix incorrect nullable in target table.
However we changed nullable info of column in source table unexpectly
@morrySnow
Copy link
Contributor Author

run buildall

yiguolei
yiguolei approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wm1581066 wm1581066 added dev/2.0.2 dev/1.2.8 usercase Important user case type label labels Sep 22, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 22, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

wm1581066
wm1581066 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@wm1581066 wm1581066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.7 seconds
stream load tsv: 594 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162501531 Bytes

@morrySnow morrySnow merged commit b5f6ace into apache:master Sep 22, 2023
@morrySnow morrySnow deleted the fix_ctas_nullable branch September 22, 2023 05:47
xiaokang pushed a commit that referenced this pull request Sep 22, 2023
@morrySnow @xiaokang
[fix](planner) ctas should not change any meta of column in source ta…
297ca92 
…ble (#24767)

if previous PR #22770. we try to fix incorrect nullable in target table.
However we changed nullable info of column in source table unexpectly
xiaokang pushed a commit that referenced this pull request Sep 23, 2023
@morrySnow @xiaokang
[fix](planner) ctas should not change any meta of column in source ta…
943858b 
…ble (#24767)

if previous PR #22770. we try to fix incorrect nullable in target table.
However we changed nullable info of column in source table unexpectly
morningman pushed a commit that referenced this pull request Sep 23, 2023
@morrySnow @morningman
[fix](planner) ctas should not change any meta of column in source ta…
600ce53 
…ble (#24767)

if previous PR #22770. we try to fix incorrect nullable in target table.
However we changed nullable info of column in source table unexpectly
htyoung pushed a commit to htyoung/doris that referenced this pull request Nov 11, 2023
@morrySnow @morningman
[fix](planner) ctas should not change any meta of column in source ta…
04d347a 
…ble (apache#24767)

if previous PR apache#22770. we try to fix incorrect nullable in target table.
However we changed nullable info of column in source table unexpectly
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Dec 11, 2023
@morrySnow
[fix](planner) ctas should not change any meta of column in source ta…
7515f09 
…ble (apache#24767)

if previous PR apache#22770. we try to fix incorrect nullable in target table.
However we changed nullable info of column in source table unexpectly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wm1581066 wm1581066 wm1581066 approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.8-merged dev/2.0.2-merged merge_conflict reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morrySnow @doris-robot @yiguolei @wm1581066 @xiaokang @morningman