-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug](materialized-view) enable rewrite on select materialized index with aggregate mode #24691
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
4f5a90a
to
161c38a
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
@@ -359,4 +359,14 @@ public void initColumnNameMap() { | |||
definedNameToColumn.put(normalizeName(column.getDefineName()), column); | |||
} | |||
} | |||
|
|||
// rollup or base column not have define expr | |||
public boolean haveDefineExpr() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not use?
|
||
Set<MaterializedIndex> candidatesWithoutRewriting = new HashSet<>(); | ||
if (!table.isDupKeysOrMergeOnWrite() && scan.getPreAggStatus().isOff()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could u add some comment to explain why add scan.getPreAggStatus().isOff()
...ain/java/org/apache/doris/nereids/rules/rewrite/mv/SelectMaterializedIndexWithAggregate.java
Show resolved
Hide resolved
161c38a
to
42c7d0f
Compare
run buildall |
1 similar comment
run buildall |
run p0 |
run ckbench |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
b6442a9
to
530d9d7
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…with aggregate mode (apache#24691) enable rewrite on select materialized index with aggregate mode
…with aggregate mode (#24691) enable rewrite on select materialized index with aggregate mode
…with aggregate mode (apache#24691) enable rewrite on select materialized index with aggregate mode
…with aggregate mode (apache#24691) enable rewrite on select materialized index with aggregate mode
Proposed changes
enable rewrite on select materialized index with aggregate mode
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...