Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](agg) windown_funnel compatibility issue with multi backends #24385

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Sep 14, 2023

Proposed changes

In a multi backends environment, compatibility issues may arise if the configurations of the BE instances are inconsistent.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrhhsg
Copy link
Member Author

mrhhsg commented Sep 14, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.95% (7973/21579)
Line Coverage: 28.91% (63886/221014)
Region Coverage: 27.84% (33158/119117)
Branch Coverage: 24.40% (17009/69710)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c54b768d9e4d84fcc0e0d65d1a2b436555493fce_c54b768d9e4d84fcc0e0d65d1a2b436555493fce/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.98 seconds
stream load tsv: 594 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162371679 Bytes

@mrhhsg mrhhsg force-pushed the fix_window_funnel_compat branch from c54b768 to 3bee173 Compare September 14, 2023 14:30
@mrhhsg
Copy link
Member Author

mrhhsg commented Sep 14, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.95% (7973/21578)
Line Coverage: 28.91% (63886/221013)
Region Coverage: 27.84% (33157/119114)
Branch Coverage: 24.40% (17010/69710)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3bee173e53d3beee4e47b65318d8b1546aab73b0_3bee173e53d3beee4e47b65318d8b1546aab73b0/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.67 seconds
stream load tsv: 599 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162327569 Bytes

@yiguolei
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.67 seconds
stream load tsv: 595 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162440866 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.96% (7975/21578)
Line Coverage: 28.91% (63906/221027)
Region Coverage: 27.85% (33172/119118)
Branch Coverage: 24.41% (17020/69714)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f9b33db96427b9482d23352ac30a801fdc147355_f9b33db96427b9482d23352ac30a801fdc147355/report/index.html

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 15, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 7fd7235 into apache:master Sep 15, 2023
xiaokang added a commit that referenced this pull request Sep 16, 2023
xiaokang added a commit that referenced this pull request Sep 17, 2023
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
@mrhhsg mrhhsg deleted the fix_window_funnel_compat branch March 13, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_b reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants