Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](datetime-func)support milliseconds_add/sub/diff and microseconds_diff #24114

Merged
merged 2 commits into from
Sep 20, 2023
Merged

[feature](datetime-func)support milliseconds_add/sub/diff and microseconds_diff #24114

merged 2 commits into from
Sep 20, 2023

Conversation

LemonLiTree
Copy link
Contributor

@LemonLiTree LemonLiTree commented Sep 8, 2023 •
edited
Loading

Proposed changes

Issue Number: close #23939

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@LemonLiTree
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.91% (7895/21387)
Line Coverage: 28.93% (63363/219047)
Region Coverage: 27.87% (32908/118057)
Branch Coverage: 24.46% (16898/69094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/51f5998f6ee4f9ed6708b43731d24f9096552d9e_51f5998f6ee4f9ed6708b43731d24f9096552d9e/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.75 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161963914 Bytes

Gabriel39
Gabriel39 previously approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LemonLiTree
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Gabriel39
Gabriel39 approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 17, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7981/21667)
Line Coverage: 28.86% (64043/221931)
Region Coverage: 27.75% (33238/119787)
Branch Coverage: 24.37% (17037/69910)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b29f9c51d49cc159615257df709f5a85e9c05245_b29f9c51d49cc159615257df709f5a85e9c05245/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.81 seconds
stream load tsv: 598 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162467742 Bytes

@LemonLiTree
Copy link
Contributor Author

run p0

@LemonLiTree
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7981/21669)
Line Coverage: 28.86% (64060/221951)
Region Coverage: 27.75% (33249/119798)
Branch Coverage: 24.38% (17044/69916)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b29f9c51d49cc159615257df709f5a85e9c05245_b29f9c51d49cc159615257df709f5a85e9c05245/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.24 seconds
stream load tsv: 601 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162529927 Bytes

@LemonLiTree
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.69 seconds
stream load tsv: 607 seconds loaded 74807831229 Bytes, about 117 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162399492 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7979/21667)
Line Coverage: 28.85% (64035/221960)
Region Coverage: 27.75% (33240/119796)
Branch Coverage: 24.36% (17034/69916)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

@LemonLiTree
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7981/21667)
Line Coverage: 28.86% (64066/221960)
Region Coverage: 27.76% (33259/119796)
Branch Coverage: 24.38% (17043/69916)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.26 seconds
stream load tsv: 600 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162255708 Bytes

@LemonLiTree
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.76% (7981/21713)
Line Coverage: 28.83% (64060/222212)
Region Coverage: 27.73% (33262/119955)
Branch Coverage: 24.35% (17045/69998)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.18 seconds
stream load tsv: 598 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162150312 Bytes

@LemonLiTree
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.75% (7979/21713)
Line Coverage: 28.82% (64051/222214)
Region Coverage: 27.73% (33259/119956)
Branch Coverage: 24.34% (17040/69998)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.61 seconds
stream load tsv: 597 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162569682 Bytes

@LemonLiTree
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.75% (7979/21713)
Line Coverage: 28.82% (64047/222217)
Region Coverage: 27.72% (33244/119948)
Branch Coverage: 24.34% (17039/69992)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

yiguolei
yiguolei approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.34 seconds
stream load tsv: 604 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162280205 Bytes

@Gabriel39 Gabriel39 merged commit e59aa49 into apache:master Sep 20, 2023
JingDas pushed a commit to JingDas/doris that referenced this pull request Sep 20, 2023
@LemonLiTree
[feature](datetime-func)support milliseconds_add/sub/diff and microse…
bc159e3 
…conds_diff (apache#24114)
@xiaokang xiaokang added usercase Important user case type label dev/2.0.3 merge_conflict labels Sep 20, 2023
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Sep 27, 2023
@LemonLiTree @xiaokang
[feature](datetime-func)support milliseconds_add/sub/diff and microse…
3b7466c 
…conds_diff (apache#24114)
xiaokang pushed a commit that referenced this pull request Oct 3, 2023
@LemonLiTree @xiaokang
[feature](datetime-func)support milliseconds_add/sub/diff and microse…
a4972cf 
…conds_diff (#24114)
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees

@Gabriel39 Gabriel39

Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 增加可以计算毫秒时间差的函数
5 participants
@LemonLiTree @doris-robot @yiguolei @Gabriel39 @xiaokang