[chore](thirdparty)We need to issue an error when starting FE without setting the Java home environment #23943
Conversation
| @@ -108,7 +108,12 @@ if [[ -e "${DORIS_HOME}/bin/palo_env.sh" ]]; then | |||
| fi | |||
|
|
|||
| if [[ -z "${JAVA_HOME}" ]]; then | |||
| JAVA="$(command -v java)" | |||
| if ! command -v java &>/dev/null; then | |||
There was a problem hiding this comment.
please add some comment here， why do we need write code like this.
Or the other developer may refactor code and rewrite this code.
There was a problem hiding this comment.
Due to the customer's machine not being configured with Java home, starting FE will result in startup failure, no error prompts, and logs. In this case, when the FE cannot start, it is necessary to prompt an error message indicating that it has not yet configured Java home.
There was a problem hiding this comment.
Hi @xyfsjq , would you show the errors here if we don't set JAVA_HOME before starting FE?
By the way, if it was caused by the environment variable JAVA_HOME which is unset, we should check the variable JAVA_HOME straightforwardly.
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
bin/start_fe.sh
Outdated
| else | ||
| JAVA="$(command -v java)" | ||
| fi | ||
| #JAVA="$(command -v java)" |
There was a problem hiding this comment.
| #JAVA="$(command -v java)" |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
… setting the Java home environment (#23943) --------- Co-authored-by: yiguolei <[email protected]>
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...