-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Nereids) fix or to in rule #23940
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
@@ -57,7 +55,7 @@ | |||
* adding any additional rule-specific fields to the default ExpressionRewriteContext. However, the entire expression | |||
* rewrite framework always passes an ExpressionRewriteContext of type context to all rules. | |||
*/ | |||
public class OrToIn extends DefaultExpressionRewriter<OrToInContext> implements | |||
public class OrToIn extends DefaultExpressionRewriter<ExpressionRewriteContext> implements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OrToInContext
is useless? Can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
or expression context can't propagation cross or expression. for example: ``` select (a = 1 or a = 2 or a = 3) + (a = 4 or a = 5 or a = 6) = select a in [1, 2, 3] + a in [4,5,6] != select a in [1, 2, 3] + a in [1, 2, 3, 4, 5, 6] ```
Proposed changes
or expression context can't propagation cross or expression.
for example:
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...