-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](planner)fix 'char' function's toSql implementation is wrong #23860
Conversation
run buildall |
} | ||
} | ||
sb.append(" using "); | ||
sb.append(children.get(0).toSql().replace("'", "")).append(")"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should use substr() to remove the first and the last character. replace will generate wrong sql, think about 'ab\'c'
dddb02a
to
289a52d
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Proposed changes
create view vv1 as select char(k2) from t2;
The create view sql should be:
CREATE VIEW
vv1
COMMENT 'VIEW' AS SELECT char(k2
using utf8) ASchar(``k2`` using utf8)
FROMdefault_cluster:tt
.t2
;Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...