[bug](distinct-agg) fix distinct-agg outblock columns size not equal key size #22357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
BiteTheDDDDt
approved these changes
Jul 29, 2023
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xiaokang
added
merge_conflict
dev/2.0.0-merged
and removed
dev/2.0.0
xiaokang
pushed a commit
that referenced
this pull request
Jul 31, 2023
…key size (#22357) * [imporve](flex) support scientific notation(aEb) parser * update * [bug](distinct-agg) fix distinct-agg outblock columns size not equal key size
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Aug 2, 2023
…key size (apache#22357) * [imporve](flex) support scientific notation(aEb) parser * update * [bug](distinct-agg) fix distinct-agg outblock columns size not equal key size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
this agg used by get distinct rows, the group by key is customer_sk and item_sk. and have a projections: customer_sk.
so the output block after call clear_column_data with num_materialized_slots will be remove item_sk column,
But the block will be push back to data_queue to reuse, those will cause the block column not equal.
| 6:VAGGREGATE (merge finalize)
| | group by: customer_sk[#58], item_sk[#59]
| | cardinality=35,999,628
| | projections: customer_sk[#60]
| | project output tuple id: 7
| 4:VAGGREGATE (update serialize)
| | STREAMING
| | group by: customer_sk[#56], item_sk[#57]
| | cardinality=71,999,256
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...