[fix](order by) fix bug of order by desc when rowsets is no overlapping #18100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
jacktengg
force-pushed
the
fix-order-desc
branch
from
c6dde16 to
1c3354c
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
1 similar comment
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
jacktengg
force-pushed
the
fix-order-desc
branch
from
6a81b79 to
758b691
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
reviewed
Mar 27, 2023
| ) ENGINE=OLAP | ||
| AGGREGATE KEY(`time_period`, `area_name`, `province`, `res_name`, `dev`) | ||
| DISTRIBUTED BY HASH(`time_period`, `area_name`, `province`, `res_name`, `dev`) BUCKETS 4 | ||
| PROPERTIES ( |
There was a problem hiding this comment.
add disable compaction;
remove distributed by
yixiutt
previously approved these changes
Mar 27, 2023
|
LGTM |
|
PR approved by anyone and no changes requested. |
jacktengg
force-pushed
the
fix-order-desc
branch
from
758b691 to
964b970
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buidlall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
yagagagaga
added a commit
to yagagagaga/doris
that referenced
this pull request
Mar 28, 2023
morningman
pushed a commit
that referenced
this pull request
Mar 28, 2023
…ng (#18100) In the case of rowets non-overlap and desc sorting, the logic of VCollectIterator::Level0Iterator::init_for_union will be followed. In this function, the row ref pos of the first level0 iterator is set to 0, and the row pos of other level0 iterators are all Set to -1. But in the level1iterator, when rowets are non-overlapping and is ordering by desc, the list of rowset iterators will be reversed, causing the row ref pos of the first level0 iterator in the list to be -1, causing the block reader to think that the entire tablet has no data.
5 tasks
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…ng (apache#18100) In the case of rowets non-overlap and desc sorting, the logic of VCollectIterator::Level0Iterator::init_for_union will be followed. In this function, the row ref pos of the first level0 iterator is set to 0, and the row pos of other level0 iterators are all Set to -1. But in the level1iterator, when rowets are non-overlapping and is ordering by desc, the list of rowset iterators will be reversed, causing the row ref pos of the first level0 iterator in the list to be -1, causing the block reader to think that the entire tablet has no data.
3 tasks
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
…ng (apache#18100) In the case of rowets non-overlap and desc sorting, the logic of VCollectIterator::Level0Iterator::init_for_union will be followed. In this function, the row ref pos of the first level0 iterator is set to 0, and the row pos of other level0 iterators are all Set to -1. But in the level1iterator, when rowets are non-overlapping and is ordering by desc, the list of rowset iterators will be reversed, causing the row ref pos of the first level0 iterator in the list to be -1, causing the block reader to think that the entire tablet has no data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
In the case of rowets non-overlap and desc sorting, the logic of VCollectIterator::Level0Iterator::init_for_union will be followed. In this function, the row ref pos of the first level0 iterator is set to 0, and the row pos of other level0 iterators are all Set to -1.
But in the level1iterator, when rowets are non-overlapping and is ordering by desc, the list of rowset iterators will be reversed, causing the row ref pos of the first level0 iterator in the list to be -1, causing the block reader to think that the entire tablet has no data.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...