Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor](schema change)Remove delete from sc #11441

Merged
merged 7 commits into from
Aug 2, 2022

Conversation

yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Aug 2, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

Currently, schema change will read a row block and call delete handler's is filter data to filter the row block. BUT rowset reader alreay filter the data during read so that there is no need to call delete handler to filter it again.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@BiteTheDDDDt
Copy link
Contributor

Better add some test about "schema change after delete" to regression-test.

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Aug 2, 2022
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit de44666 into apache:master Aug 2, 2022
@yiguolei
Copy link
Contributor Author

yiguolei commented Aug 3, 2022

part of #10136

@yiguolei yiguolei deleted the remove_delete_from_sc branch March 30, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants