update

apache · Nov 2, 2023 · 6041a99 · 6041a99
1 parent 8c312df
commit 6041a99
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java b/fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java
@@ -685,7 +685,8 @@ public void commitTransaction(List<Table> tableList, long transactionId, List<Ta
                     if (table != null && table instanceof OlapTable) {
                         if (!transactionState.checkSchemaCompatibility((OlapTable) table)) {
                             throw new TransactionCommitFailedException("transaction [" + transactionId
-                                    + "] check schema compatibility failed");
+                                    + "] check schema compatibility failed, partial update can't commit with"
+                                            + " old schema sucessfully .");
                         }
                     }
                 }
@@ -694,7 +695,8 @@ public void commitTransaction(List<Table> tableList, long transactionId, List<Ta
                     if (table instanceof OlapTable) {
                         if (!transactionState.checkSchemaCompatibility((OlapTable) table)) {
                             throw new TransactionCommitFailedException("transaction [" + transactionId
-                                    + "] check schema compatibility failed");
+                                    + "] check schema compatibility failed, partial update can't commit with"
+                                            + " old schema sucessfully .");
                         }
                     }
                 }

diff --git a/fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionState.java b/fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionState.java
@@ -778,6 +778,8 @@ public boolean checkSchemaCompatibility(OlapTable olapTable) {
             int uniqueId = txnCol.getUniqueId();
             Optional<Column> currentCol = currentSchemaInfo.schema.stream()
                     .filter(col -> col.getUniqueId() == uniqueId).findFirst();
+            // for now Doris's light schema change only supports adding columns,
+            // dropping columns, and type conversions that increase the varchar length
             if (currentCol.isPresent() && currentCol.get().getType().isStringType()) {
                 if (currentCol.get().getStrLen() != txnCol.getStrLen()) {
                     LOG.warn("Check schema compatibility failed, txnId={}, table={}",