Skip to content

Commit

Permalink
branch-3.0: [Fix](ShortCircuit) fix open segments leading to bad perf…
Browse files Browse the repository at this point in the history
…ormace #44073 (#44077)

Cherry-picked from #44073

Co-authored-by: lihangyu <[email protected]>
  • Loading branch information
github-actions[bot] and eldenmoon authored Nov 17, 2024
1 parent 6e3751a commit 502126a
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions be/src/service/point_query_executor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -396,17 +396,6 @@ Status PointQueryExecutor::_lookup_row_key() {
specified_rowsets = _tablet->get_rowset_by_ids(nullptr);
}
std::vector<std::unique_ptr<SegmentCacheHandle>> segment_caches(specified_rowsets.size());
// init segment_cache
{
SCOPED_TIMER(&_profile_metrics.load_segment_key_stage_ns);
for (size_t i = 0; i < specified_rowsets.size(); i++) {
auto& rs = specified_rowsets[i];
segment_caches[i] = std::make_unique<SegmentCacheHandle>();
RETURN_IF_ERROR(SegmentLoader::instance()->load_segments(
std::static_pointer_cast<BetaRowset>(rs), segment_caches[i].get(), true, true,
&_profile_metrics.read_stats));
}
}
for (size_t i = 0; i < _row_read_ctxs.size(); ++i) {
RowLocation location;
if (!config::disable_storage_row_cache) {
Expand Down

0 comments on commit 502126a

Please sign in to comment.