Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16174] Incorrect cluster installation guide. #16208

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

Fix #16174

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS requested a review from EricGao888 as a code owner June 25, 2024 06:01
@SbloodyS SbloodyS self-assigned this Jun 25, 2024
@SbloodyS SbloodyS added bug Something isn't working 3.3.0 labels Jun 25, 2024
@SbloodyS SbloodyS requested a review from ruanwenjun June 25, 2024 06:03
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.31%. Comparing base (d022966) to head (a89ce81).

Current head a89ce81 differs from pull request most recent head 93a315b

Please upload reports for the commit 93a315b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #16208   +/-   ##
=========================================
  Coverage     41.31%   41.31%           
  Complexity     5162     5162           
=========================================
  Files          1403     1403           
  Lines         44423    44423           
  Branches       4721     4721           
=========================================
  Hits          18355    18355           
  Misses        24264    24264           
  Partials       1804     1804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanwenjun
ruanwenjun previously approved these changes Jun 25, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS requested a review from Radeity June 25, 2024 13:14
# Deploy user, use the user you create in section **Configure machine SSH password-free login**
deployUser="dolphinscheduler"
```
完成基础环境的准备后,需要根据你的机器环境修改配置文件。配置文件可以在目录 `bin/env` 中找到,他们分别是 `dolphinscheduler_env.sh`。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If do not have other configuration file, maybe remove “分别是”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS requested a review from ruanwenjun June 25, 2024 13:48
Copy link

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit c3d3a14 into apache:dev Jun 26, 2024
64 checks passed
@SbloodyS SbloodyS deleted the fix_16174 branch June 26, 2024 02:38
@SbloodyS SbloodyS added 3.2.2 and removed 3.3.0 labels Jun 26, 2024
@SbloodyS SbloodyS modified the milestones: 3.3.0, 3.2.2 Jun 26, 2024
SbloodyS added a commit to SbloodyS/dolphinscheduler that referenced this pull request Jun 26, 2024
SbloodyS added a commit that referenced this pull request Jun 26, 2024
* [Fix-16174] Incorrect cluster installation guide. (#16208)

* [Fix][CI] fix the ci error of Values.datasource.profile (#16031)

* [Improvement][Helm] Make configmap of api/master/worker/alert configuration (#16058)

Update deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml

* Update deploy/kubernetes/dolphinscheduler/values.yaml

* [helm] remove appversion from labels (#16066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend bug Something isn't working document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [service down] service down and stop when use bash bin/start-all.sh a few seconds
4 participants