Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task instance which status is dispatch will not be failover #16107

Merged

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

The dispatched task need to take-over

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Jun 3, 2024
@ruanwenjun ruanwenjun added priority:high bug Something isn't working and removed backend labels Jun 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.66%. Comparing base (4f6e715) to head (10a12e7).

Current head 10a12e7 differs from pull request most recent head 5e02066

Please upload reports for the commit 5e02066 to get more accurate results.

Files Patch % Lines
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16107      +/-   ##
============================================
- Coverage     40.67%   40.66%   -0.01%     
+ Complexity     5238     5236       -2     
============================================
  Files          1382     1382              
  Lines         46020    46020              
  Branches       4921     4921              
============================================
- Hits          18718    18716       -2     
  Misses        25379    25379              
- Partials       1923     1925       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Jun 3, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixDispatchTaskFailover branch from a59ecf2 to 5e02066 Compare June 5, 2024 02:01
Copy link

sonarqubecloud bot commented Jun 5, 2024

@ruanwenjun ruanwenjun merged commit 5867bee into apache:dev Jun 5, 2024
63 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixDispatchTaskFailover branch November 23, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants