Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-42] Add dolphinscheduler-aws-authentication module #16043

Merged
merged 5 commits into from
May 24, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented May 21, 2024

Purpose of the pull request

close #16024

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun marked this pull request as draft May 21, 2024 03:12
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch from b9dd12f to 328fcd3 Compare May 21, 2024 03:36
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 40.67%. Comparing base (baa252a) to head (04d0940).

Current head 04d0940 differs from pull request most recent head dddb42d

Please upload reports for the commit dddb42d to get more accurate results.

Files Patch % Lines
...cheduler/common/log/remote/S3RemoteLogHandler.java 0.00% 3 Missing ⚠️
...phinscheduler/plugin/task/emr/AbstractEmrTask.java 0.00% 2 Missing ⚠️
...scheduler/plugin/task/sagemaker/SagemakerTask.java 0.00% 2 Missing ⚠️
...scheduler/plugin/storage/s3/S3StorageOperator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16043      +/-   ##
============================================
+ Coverage     40.61%   40.67%   +0.05%     
- Complexity     5220     5225       +5     
============================================
  Files          1380     1380              
  Lines         46069    46011      -58     
  Branches       4917     4919       +2     
============================================
+ Hits          18711    18714       +3     
+ Misses        25433    25371      -62     
- Partials       1925     1926       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch from 328fcd3 to e1d479e Compare May 21, 2024 04:05
@ruanwenjun ruanwenjun changed the title Add dolphinscheduler-aws-authentication module [DSIP-42] Add aws-authentication module May 21, 2024
@ruanwenjun ruanwenjun self-assigned this May 21, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch 6 times, most recently from 2e525ee to be5874c Compare May 21, 2024 08:56
@ruanwenjun ruanwenjun marked this pull request as ready for review May 21, 2024 08:56
@ruanwenjun ruanwenjun requested a review from EricGao888 as a code owner May 21, 2024 08:56
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch 4 times, most recently from b2fca02 to a4d8d58 Compare May 21, 2024 12:40
@ruanwenjun ruanwenjun changed the title [DSIP-42] Add aws-authentication module [DSIP-42] Add dolphinscheduler-aws-authentication module May 21, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch from a4d8d58 to 0046dab Compare May 21, 2024 14:19
@github-actions github-actions bot added the e2e e2e test label May 21, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch 2 times, most recently from f6faf37 to ad4709e Compare May 22, 2024 02:52
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch 4 times, most recently from 8edc688 to 5dc9099 Compare May 22, 2024 05:37
@ruanwenjun ruanwenjun requested review from Radeity and rickchengx May 22, 2024 06:32
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch 2 times, most recently from 0b02963 to 73368e1 Compare May 22, 2024 07:42
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

deploy/kubernetes/dolphinscheduler/values.yaml Outdated Show resolved Hide resolved
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch 2 times, most recently from bc0ed49 to 10b59c3 Compare May 22, 2024 14:30
@ruanwenjun ruanwenjun requested review from Radeity and Gallardot May 22, 2024 14:31
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAwsAuthentication branch from 8a058e8 to 5bdc697 Compare May 24, 2024 02:34
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.3% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@ruanwenjun ruanwenjun merged commit f754611 into apache:dev May 24, 2024
62 of 64 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_addAwsAuthentication branch May 24, 2024 06:15
wangxj3 added a commit that referenced this pull request May 25, 2024
…ASF release (#16042)

* add version of 3.2.2

* Fix rpc channel leak due to concurrent operation (#16021)

* Fix rpc channel leak due to concurrent operation

* Throw channel create failed exception

---------

Co-authored-by: Rick Cheng <[email protected]>

* Fix WorkerTaskExecutorThreadPool#isOverload is incorrect (#16027)

* cp: Reduce the size of tarball to continue ASF release (#15004) (#15540)

* Reduce the size of tarball to continue ASF release

for more detail you can see https://lists.apache.org/thread/rmp7fghlj0n7h9y2v3p8gkw9f9qbo6qt
# Conflicts:
#	tools/dependencies/known-dependencies.txt

* Increase block-until-connected in ZookeeperRegistryTestCase (#16041)

* [Fix][CI] fix the ci error of Values.datasource.profile (#16031)

Co-authored-by: Eric Gao <[email protected]>

* Correction of Typos in the Chinese Document Appendix for Task Parameters (#16033)

Co-authored-by: Rick Cheng <[email protected]>

* [DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type (#15967)

* [Improvement][parameter] New data types and type filtering

* [Improvement][parameter] Improvement startup parameters/global parameters data type

* fix api interfaces compatible

* add project parameter data type default value

* [Improvement][parameter] New data types and type filtering

* [Improvement][parameter] Improvement startup parameters/global parameters data type

* fix api interfaces compatible

* add project parameter data type default value

* improvement project code

* remove useless imports

* remove method onClearSearchTaskType

* add parameter doc

* optimisation logic

* code conflict resolution

* code conflict resolution

* [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list (#15978)

* update

* test

* add monitor enhance ui

* update

* update

* update doc

* fix spotless

* update

* update

* Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java

Co-authored-by: Wenjun Ruan <[email protected]>

* Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml

Co-authored-by: Wenjun Ruan <[email protected]>

* update

* fix spotless

* update

---------

Co-authored-by: Wenjun Ruan <[email protected]>

* [Improvement][Monitor] Add UT for montor (#15998)

* formatting Code

* add pom

* Fix NettyRemotingClient might throw IllegalMonitorStateException (#16038)

* Removed unused StateEventHandleFailure (#16052)

* Remove OmitStackTraceInFastThrow in start.sh (#16054)

* Update Chart.yaml Rollback APPversion

* modify log msg (#16062)

Co-authored-by: xiangzihao <[email protected]>

* [DS-16046][fix] Set PreparedStatement parameter type (#16050)

Fix the PreparedStatement parameter is TIME, set it to java.sql.Time

Co-authored-by: Aaron Wang <[email protected]>
Co-authored-by: Rick Cheng <[email protected]>

* Update pom.xml

* [DSIP-42] Add dolphinscheduler-aws-authentication module  (#16043)

---------

Co-authored-by: wangxj <wangxj31>
Co-authored-by: Wenjun Ruan <[email protected]>
Co-authored-by: Rick Cheng <[email protected]>
Co-authored-by: Eric Gao <[email protected]>
Co-authored-by: TianXinCoord <[email protected]>
Co-authored-by: 小可耐 <[email protected]>
Co-authored-by: sleo <[email protected]>
Co-authored-by: xiangzihao <[email protected]>
Co-authored-by: yinxiaolog <[email protected]>
Co-authored-by: Aaron Wang <[email protected]>
@pegasas pegasas mentioned this pull request May 27, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSIP-42] Add dolphinscheduler-aws-authentication module
5 participants