[Fix-15937] Add tenantCode propagation to DynamicCommandUtils.createCommand #15956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15956 +/- ##
=========================================
Coverage 39.86% 39.86%
- Complexity 5060 5064 +4
=========================================
Files 1369 1369
Lines 45634 45635 +1
Branches 4869 4868 -1
=========================================
+ Hits 18192 18193 +1
Misses 25544 25544
Partials 1898 1898 ☔ View full report in Codecov by Sentry. |
SbloodyS
changed the title
Fix DynamicCommandUtils.createCommand method by adding command.setTenantCode(processInstance.getTenantCode()) line. This ensures that the tenantCode is correctly propagated to all subtasks in DolphinScheduler's Dynamic tasks, addressing an issue where the tenantCode wasn't being passed to subtasks, resulting in null tenantCodes for subtask commands. Closes: apache#15937
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DynamicCommandUtils.createCommand method by adding command.setTenantCode(processInstance.getTenantCode()) line. This ensures that the tenantCode is correctly propagated to all subtasks in DolphinScheduler's Dynamic tasks, addressing an issue where the tenantCode wasn't being passed to subtasks, resulting in null tenantCodes for subtask commands. Closes: #15937
Purpose of the pull request
This pull request addresses the issue described in #15937 by ensuring proper propagation of the tenantCode to all subtasks in DolphinScheduler's Dynamic tasks.
Brief change log
Verify this pull request
This pull request is already covered by existing tests.