Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing the scope of RPC base classes #15946

Merged
merged 2 commits into from
May 8, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 30, 2024

Purpose of the pull request

  • Change some class/method level to package level.
  • Add UT to initialize Master/Worker/Alert RpcServer

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 39.78%. Comparing base (ebcdaeb) to head (5c1c781).

❗ Current head 5c1c781 differs from pull request most recent head b703c5e. Consider uploading reports for the commit b703c5e to get more accurate results

Files Patch % Lines
...olphinscheduler/extract/base/server/RpcServer.java 80.00% 2 Missing and 2 partials ⚠️
...ase/server/SpringServerMethodInvokerDiscovery.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15946      +/-   ##
============================================
- Coverage     39.79%   39.78%   -0.02%     
+ Complexity     5044     5032      -12     
============================================
  Files          1353     1354       +1     
  Lines         45619    45601      -18     
  Branches       4891     4890       -1     
============================================
- Hits          18156    18141      -15     
+ Misses        25553    25550       -3     
  Partials       1910     1910              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. labels Apr 30, 2024
@ruanwenjun ruanwenjun self-assigned this Apr 30, 2024
@ruanwenjun ruanwenjun marked this pull request as draft April 30, 2024 15:10
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_improveRpcServer branch from a076303 to b703c5e Compare May 1, 2024 04:07
@ruanwenjun ruanwenjun changed the title Don't expose rpc component to outside Optimizing the scope of RPC base classes May 1, 2024
@ruanwenjun ruanwenjun marked this pull request as ready for review May 1, 2024 04:08
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_improveRpcServer branch from b703c5e to 090eb18 Compare May 1, 2024 06:22
Radeity
Radeity previously approved these changes May 5, 2024
rickchengx
rickchengx previously approved these changes May 6, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_improveRpcServer branch from 9ac5da5 to 5209b2b Compare May 6, 2024 10:07
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone May 6, 2024
@ruanwenjun ruanwenjun dismissed stale reviews from Radeity and rickchengx via 38acf95 May 6, 2024 11:10
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_improveRpcServer branch from 5209b2b to 38acf95 Compare May 6, 2024 11:10
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_improveRpcServer branch from 38acf95 to ccbb150 Compare May 6, 2024 11:10
Copy link

sonarqubecloud bot commented May 6, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@ruanwenjun ruanwenjun requested review from rickchengx and Radeity May 7, 2024 01:55
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 99d8276 into apache:dev May 8, 2024
61 of 62 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_improveRpcServer branch May 31, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants