-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSIP-28] Donnot scan whole project beans under classpath #15874
[DSIP-28] Donnot scan whole project beans under classpath #15874
Conversation
d8eb823
to
108fd39
Compare
108fd39
to
85b09fd
Compare
3758120
to
9cd3f14
Compare
...pi/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Wait for CI
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15874 +/- ##
============================================
+ Coverage 39.52% 39.60% +0.07%
- Complexity 5002 5015 +13
============================================
Files 1348 1349 +1
Lines 45674 45578 -96
Branches 4896 4886 -10
============================================
- Hits 18053 18051 -2
+ Misses 25698 25609 -89
+ Partials 1923 1918 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, This avoids loading unnecessary beans
9cd3f14
to
d8aeb9f
Compare
|
Purpose of the pull request
close #15877
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md