[Bug] Close SSH session after remote shell finish #15348
Merged
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15348 +/- ##
=========================================
Coverage 37.80% 37.81%
Complexity 4681 4681
=========================================
Files 1304 1304
Lines 44933 44934 +1
Branches 4811 4811
=========================================
+ Hits 16989 16990 +1
Misses 26095 26095
Partials 1849 1849 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...eshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteExecutor.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_addSSHRetry
branch
2 times, most recently
from
ff71d8c to
be99324
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addSSHRetry
branch
3 times, most recently
from
c295794 to
c54b15c
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addSSHRetry
branch
from
7f62ef6 to
a0fe61f
Compare
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Fix remote ssh will cause thread leak.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md