Minor: Avoid copying all expressions in Analzyer / check_plan
#9974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 6, 2024
| @@ -156,18 +155,21 @@ impl Analyzer { | |||
| /// Do necessary check and fail the invalid plan | |||
| fn check_plan(plan: &LogicalPlan) -> Result<()> { | |||
| plan.apply(&mut |plan: &LogicalPlan| { | |||
| for expr in plan.expressions().iter() { | |||
| plan.inspect_expressions(|expr| { | |||
There was a problem hiding this comment.
this is the line that voids a copy
There was a problem hiding this comment.
A great catch! expressions() will invoke clone() inside, we can notice it to reduce some loss
peter-toth
approved these changes
Apr 6, 2024
jackwener
approved these changes
Apr 7, 2024
This was referenced Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9637
Rationale for this change
I found this while working on #9913 with @peter-toth
Calling
LogicalPlan::expressions()does a copy of the expressions, but this function simply needs to check themWhat changes are included in this PR?
TreeNodeAPI to visit expressions rather thanLogicalPlan::expressions()Are these changes tested?
Covered by existing unit tests
Are there any user-facing changes?
(Slightly) faster planning, and fewer copies during planning