Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Improve documentation about optimizer #9967

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 5, 2024

Which issue does this PR close?

Part of #7013

Rationale for this change

@comphead suggested we have some better documentation of the Optimizer rules #9959 (review) and I agree!

What changes are included in this PR?

Update the documentation of the Optimizer so we now have a summary of the available rules

Here is what the docs look like now:

Screenshot 2024-04-05 at 4 33 13 PM

Are these changes tested?

CI doc tests

Are there any user-facing changes?

No, just doc changes

@alamb
Copy link
Contributor Author

alamb commented Apr 6, 2024

Thanks for the review @Jefffrey

@alamb
Copy link
Contributor Author

alamb commented Apr 6, 2024

One thing I found that was strange is that the push_down_projection module actually has no code (it is only tests for optimize_projections) It would be cool if we could consolidate the tests for push_down_projection into optimize_projections

@Jefffrey
Copy link
Contributor

Jefffrey commented Apr 6, 2024

One thing I found that was strange is that the push_down_projection module actually has no code (it is only tests for optimize_projections) It would be cool if we could consolidate the tests for push_down_projection into optimize_projections

Raised #9978

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It looks better now

@waynexia waynexia merged commit 1a002bc into apache:main Apr 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants