Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for reading back file created with COPY ... OPTIONS (FORMAT..) options #9753

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Add test for reading back file created with COPY ... OPTIONS (FORMAT..) options #9753

merged 3 commits into from
Apr 1, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 23, 2024

Which issue does this PR close?

Follow on to #9744

Rationale for this change

The tests in #9744 show the syntax works, but doesn't verify that the format is actually used (rather than say, being ignored)

What changes are included in this PR?

Add a test to write to a file with a non standard extension and then read it back

Are these changes tested?

Are there any user-facing changes?

no, tests only

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Mar 23, 2024
@alamb alamb mentioned this pull request Mar 23, 2024
Merged
@alamb alamb changed the title Add test for reading back file created with FORMAT options Add test for reading back file created with COPY ... OPTIONS (FORMAT..) options Mar 23, 2024
@alamb
Copy link
Contributor Author

alamb commented Mar 29, 2024

@metesynnada here is another small PR with tests that I wonder if you have time to review?

metesynnada
metesynnada approved these changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@metesynnada metesynnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we phase out this usage at some point, or continue to support both options going forward?

@alamb alamb mentioned this pull request Apr 1, 2024
Closed
@alamb
Copy link
Contributor Author

alamb commented Apr 1, 2024

Should we phase out this usage at some point, or continue to support both options going forward?

That is a good question. I filed #9905 to discuss. I don't have a strong opinion

@alamb alamb merged commit b50f3aa into apache:main Apr 1, 2024
24 checks passed
tinfoil-knight added a commit to tinfoil-knight/arrow-datafusion that referenced this pull request Apr 7, 2024
@tinfoil-knight
Revert "Add test for reading back file created with FORMAT options (a…
e70d8dd 
…pache#9753)"

This reverts commit b50f3aa.
@tinfoil-knight tinfoil-knight mentioned this pull request Apr 7, 2024
Merged
alamb pushed a commit that referenced this pull request Apr 8, 2024
@tinfoil-knight
Remove FORMAT <..> backwards compatibility options from COPY (#9985)
0088c28 
* Revert "Add test for reading back file created with FORMAT options (#9753)"

This reverts commit b50f3aa.

* Revert "support format in options of COPY command (#9744)"

This reverts commit 40fb1b8.

* update docs and example to remove old syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metesynnada metesynnada metesynnada approved these changes

Assignees
No one assigned
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @metesynnada