-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom struct field names with new scalar function named_struct #9743
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d151463
Support custom struct field names with new scalar function named_struct
gstvg 774ce11
add tests and corretly handle mixed arrray and scalar values
gstvg 0010a1f
Merge remote-tracking branch 'upstream/main' into named_struct
gstvg 79766d5
fix slt
alamb 44c66b7
Merge remote-tracking branch 'apache/main' into named_struct
alamb 0c22ce6
fmt
alamb f35cddc
port test to slt
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,196 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
use arrow::array::StructArray; | ||
use arrow::datatypes::{DataType, Field, Fields}; | ||
use datafusion_common::{exec_err, internal_err, Result, ScalarValue}; | ||
use datafusion_expr::{ColumnarValue, Expr, ExprSchemable}; | ||
use datafusion_expr::{ScalarUDFImpl, Signature, Volatility}; | ||
use std::any::Any; | ||
use std::sync::Arc; | ||
|
||
/// put values in a struct array. | ||
fn named_struct_expr(args: &[ColumnarValue]) -> Result<ColumnarValue> { | ||
// do not accept 0 arguments. | ||
if args.is_empty() { | ||
return exec_err!("named_struct requires at least one pair of arguments, got 0 instead"); | ||
} | ||
|
||
if args.len() % 2 != 0 { | ||
return exec_err!("named_struct requires an even number of arguments, got {} instead", args.len()); | ||
} | ||
|
||
let (names, values): (Vec<_>, Vec<_>) = args | ||
.chunks_exact(2) | ||
.enumerate() | ||
.map(|(i, chunk)| { | ||
|
||
let name_column = &chunk[0]; | ||
|
||
let name = match name_column { | ||
ColumnarValue::Scalar(ScalarValue::Utf8(Some(name_scalar))) => name_scalar, | ||
_ => return exec_err!("named_struct even arguments must be string literals, got {name_column:?} instead at position {}", i * 2) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❤️ |
||
}; | ||
|
||
Ok((name, chunk[1].clone())) | ||
}) | ||
.collect::<Result<Vec<_>>>()? | ||
.into_iter() | ||
.unzip(); | ||
|
||
let arrays = ColumnarValue::values_to_arrays(&values)?; | ||
|
||
let fields = names.into_iter() | ||
.zip(arrays) | ||
.map(|(name, value)| { | ||
( | ||
Arc::new(Field::new( | ||
name, | ||
value.data_type().clone(), | ||
true, | ||
)), | ||
value, | ||
) | ||
}) | ||
.collect::<Vec<_>>(); | ||
|
||
Ok(ColumnarValue::Array(Arc::new(StructArray::from(fields)))) | ||
} | ||
|
||
#[derive(Debug)] | ||
pub(super) struct NamedStructFunc { | ||
signature: Signature, | ||
} | ||
|
||
impl NamedStructFunc { | ||
pub fn new() -> Self { | ||
Self { | ||
signature: Signature::variadic_any(Volatility::Immutable), | ||
} | ||
} | ||
} | ||
|
||
impl ScalarUDFImpl for NamedStructFunc { | ||
fn as_any(&self) -> &dyn Any { | ||
self | ||
} | ||
|
||
fn name(&self) -> &str { | ||
"named_struct" | ||
} | ||
|
||
fn signature(&self) -> &Signature { | ||
&self.signature | ||
} | ||
|
||
fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> { | ||
internal_err!("named_struct: return_type called instead of return_type_from_exprs") | ||
} | ||
|
||
fn return_type_from_exprs( | ||
&self, | ||
args: &[datafusion_expr::Expr], | ||
schema: &dyn datafusion_common::ExprSchema, | ||
_arg_types: &[DataType], | ||
) -> Result<DataType> { | ||
// do not accept 0 arguments. | ||
if args.is_empty() { | ||
return exec_err!("named_struct requires at least one pair of arguments, got 0 instead"); | ||
} | ||
|
||
if args.len() % 2 != 0 { | ||
return exec_err!("named_struct requires an even number of arguments, got {} instead", args.len()); | ||
} | ||
|
||
let return_fields = args | ||
.chunks_exact(2) | ||
.enumerate() | ||
.map(|(i, chunk)| { | ||
let name = &chunk[0]; | ||
let value = &chunk[1]; | ||
|
||
if let Expr::Literal(ScalarValue::Utf8(Some(name))) = name { | ||
Ok(Field::new(name, value.get_type(schema)?, true)) | ||
} else { | ||
exec_err!("named_struct even arguments must be string literals, got {name} instead at position {}", i * 2) | ||
} | ||
}) | ||
.collect::<Result<Vec<Field>>>()?; | ||
Ok(DataType::Struct(Fields::from(return_fields))) | ||
} | ||
|
||
fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> { | ||
named_struct_expr(args) | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use super::*; | ||
use arrow::array::Int64Array; | ||
use datafusion_common::cast::as_struct_array; | ||
use datafusion_common::ScalarValue; | ||
|
||
#[test] | ||
fn test_named_struct() { | ||
// named_struct("first", 1, "second", 2, "third", 3) = {"first": 1, "second": 2, "third": 3} | ||
gstvg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
let args = [ | ||
ColumnarValue::Scalar(ScalarValue::Utf8(Some("first".into()))), | ||
ColumnarValue::Scalar(ScalarValue::Int64(Some(1))), | ||
ColumnarValue::Scalar(ScalarValue::Utf8(Some("second".into()))), | ||
ColumnarValue::Scalar(ScalarValue::Int64(Some(2))), | ||
ColumnarValue::Scalar(ScalarValue::Utf8(Some("third".into()))), | ||
ColumnarValue::Scalar(ScalarValue::Int64(Some(3))), | ||
]; | ||
let struc = named_struct_expr(&args) | ||
.expect("failed to initialize function struct") | ||
.into_array(1) | ||
.expect("Failed to convert to array"); | ||
let result = | ||
as_struct_array(&struc).expect("failed to initialize function struct"); | ||
assert_eq!( | ||
&Int64Array::from(vec![1]), | ||
result | ||
.column_by_name("first") | ||
.unwrap() | ||
.clone() | ||
.as_any() | ||
.downcast_ref::<Int64Array>() | ||
.unwrap() | ||
); | ||
assert_eq!( | ||
&Int64Array::from(vec![2]), | ||
result | ||
.column_by_name("second") | ||
.unwrap() | ||
.clone() | ||
.as_any() | ||
.downcast_ref::<Int64Array>() | ||
.unwrap() | ||
); | ||
assert_eq!( | ||
&Int64Array::from(vec![3]), | ||
result | ||
.column_by_name("third") | ||
.unwrap() | ||
.clone() | ||
.as_any() | ||
.downcast_ref::<Int64Array>() | ||
.unwrap() | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than adding a new function, I think we could instead change the existing
struct
UDF to support explicit named fields.Perhaps we can do that as a follow on PR?