Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Remove datafusion-functions-array dependency from datafusion-optimizer #9621

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 15, 2024

Which issue does this PR close?

Part of #9285

Rationale for this change

We are trying to decouple the functions from the rest of the system so the core functionality doesn't directly depend on the specific function packages.

What changes are included in this PR?

  1. Remove the explicit dependency on datafusion-functions-array from datafusion-optimizer
  2. Port a test to sqllogictests

Are these changes tested?

Yes

Are there any user-facing changes?

No (maybe slightly faster compile speeds)

Unverified

This user has not yet uploaded their public signing key.
@github-actions github-actions bot added optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) labels Mar 15, 2024
@@ -1257,51 +1255,6 @@ mod test {
Ok(())
}

#[test]
fn test_casting_for_fixed_size_list() -> Result<()> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ported this test to .slt as it was the only actual use of datafusion_functions_array in this crate

@@ -45,7 +44,6 @@ async-trait = { workspace = true }
chrono = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
datafusion-expr = { workspace = true }
datafusion-functions-array = { workspace = true, optional = true }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the point of the PR was to remove this line

@alamb alamb changed the title Remove datafusion-functions-array dependency from datafusion-optimizer Minor: Remove datafusion-functions-array dependency from datafusion-optimizer Mar 15, 2024
@alamb alamb marked this pull request as ready for review March 15, 2024 14:37
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@jayzhan211 jayzhan211 merged commit 00a1225 into apache:main Mar 16, 2024
25 checks passed
@alamb alamb deleted the alamb/reduce_func_dep branch March 16, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants