Port StringToArray to function-arrays subcrate
#9543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
jayzhan211
reviewed
Mar 11, 2024
|
|
||
| #[tokio::test] | ||
| async fn test_fn_string_to_array() -> Result<()> { | ||
| let expr = string_to_array(lit("abc##def##ghi"), lit("##"), lit("!")); |
There was a problem hiding this comment.
Some test cases are already covered in array.slt
There was a problem hiding this comment.
Firstly, thanks for the review. Addressed.
jayzhan211
reviewed
Mar 11, 2024
| @@ -3113,6 +3113,7 @@ _Alias of [make_array](#make_array)._ | |||
| ### `string_to_array` | |||
|
|
|||
| Splits a string in to an array of substrings based on a delimiter. Any substrings matching the optional `null_str` argument are replaced with NULL. | |||
| `SELECT string_to_array('abc##def', '##')` or `SELECT string_to_array('abc def', ' ', 'def')` | |||
|
You can follow the |
erenavsarogullari
changed the title
erenavsarogullari
changed the title
StringToArray to function-arrays subcrate
jayzhan211
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9497.
What changes are included in this PR?
This PR aims to do following changes in terms of Epic #9285:
1- Port
StringToArraytofunction-arrayssubcrate,2- Argument length check is added to
string_to_arrayfunction: ref3- Case: delimiter is
NULLwas breaking test case underarray.sltsuch asSELECT string_to_array('abc', NULL). This case is also handled: ref4- Function Documentation is added.
Are these changes tested?
Yes, all
array.sltbasedstring_to_arraytests are passed.Are there any user-facing changes?
No