Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: fixed transformed state in UDF Simplify #9484

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 6, 2024

Which issue does this PR close?

Follow on to #9304

Rationale for this change

@Omega359 pointed out this issue on #9304 (comment)

What changes are included in this PR?

Fix logic inversion bug.

Are these changes tested?

No test changes due to rationale explained on #9304 (comment)

Are there any user-facing changes?

No

@alamb alamb changed the title Minor: fixed transformed state return Minor: fixed transformed state in UDF Simplify Mar 6, 2024
@github-actions github-actions bot added the optimizer Optimizer rules label Mar 6, 2024
@Omega359
Copy link
Contributor

Omega359 commented Mar 6, 2024

Thanks.

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 9cf44c2 into apache:main Mar 8, 2024
23 checks passed
@alamb
Copy link
Contributor Author

alamb commented Mar 8, 2024

Thank you for the review @jayzhan211

@alamb alamb deleted the alamb/fix_logic branch March 8, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants