Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement spilling for PartialSortExec #9469

Closed
wants to merge 5 commits into from
Closed

Implement spilling for PartialSortExec #9469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93b6f21
fix typo
yyy1000 Feb 21, 2024
3947b20
Merge branch 'spill' of https://github.com/yyy1000/arrow-datafusion i…
yyy1000 Mar 3, 2024
d7406a8
initial try
yyy1000 Mar 4, 2024
9c6bc44
feat: reuse external sorter to implement partial sort
yyy1000 Mar 5, 2024
7ed2bfa
generally applicable partial sort
yyy1000 Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions datafusion/core/src/physical_optimizer/enforce_sorting.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,6 @@ fn replace_with_partial_sort(
let plan_any = plan.as_any();
if let Some(sort_plan) = plan_any.downcast_ref::<SortExec>() {
let child = sort_plan.children()[0].clone();
if !child.execution_mode().is_unbounded() {
return Ok(plan);
}

// here we're trying to find the common prefix for sorted columns that is required for the
// sort and already satisfied by the given ordering
Expand Down
Loading
Loading