Use setup-macos-aarch64-builder for aarch64 CI pipeline #9242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Feb 15, 2024
| @@ -322,7 +322,7 @@ jobs: | |||
| with: | |||
| submodules: true | |||
| - name: Setup Rust toolchain | |||
| uses: ./.github/actions/setup-macos-builder | |||
| uses: ./.github/actions/setup-macos-aarch64-builder | |||
There was a problem hiding this comment.
should we remove ./.github/actions/setup-macos-builder ?
There was a problem hiding this comment.
EDIT: my bad this change for aarch64 only
comphead
approved these changes
Feb 15, 2024
viirya
commented
Feb 15, 2024
| @@ -322,7 +322,7 @@ jobs: | |||
| with: | |||
| submodules: true | |||
| - name: Setup Rust toolchain | |||
| uses: ./.github/actions/setup-macos-builder | |||
| uses: ./.github/actions/setup-macos-aarch64-builder | |||
There was a problem hiding this comment.
I didn't point to correct builder in #9191. Although it seems also working. 🤔
|
Thanks @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
A follow up to #9191.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?