chore: make tokio a workspace dependency #9187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chojan Shang <[email protected]>
github-actions
bot
added
physical-expr
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
alamb
reviewed
Feb 10, 2024
There was a problem hiding this comment.
Thank you @PsiACE -- this is very much appreciated 🙏
The only thing I am worried about is the change to WASM compilation. I think @jonmmease or @waynexia may know more about this and perhaps can offer an opinion
|
I don't have full context on the motivation here, but would it be possible to specify tokio as a workspace dependency with no default features, and then include the features as needed in the individual crates? This way the version stays in sync but there wouldn't need to be changes to the features that are enabled for the individual crates. |
Signed-off-by: Chojan Shang <[email protected]>
PsiACE
force-pushed
the
workspace-tokio
branch
from
b826fc6 to
35dda64
Compare
PsiACE
force-pushed
the
workspace-tokio
branch
from
c63ad5c to
e57ac65
Compare
Signed-off-by: Chojan Shang <[email protected]>
PsiACE
force-pushed
the
workspace-tokio
branch
from
e57ac65 to
0b51e0b
Compare
|
Thanks again @PsiACE and @jonmmease |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9165 .
Rationale for this change
As described in #9165
What changes are included in this PR?
make tokio a workspace dependency
Are these changes tested?
Yes
Are there any user-facing changes?
No