Return proper number of expressions for nth_value_agg #9044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
comphead
reviewed
Jan 29, 2024
scsmithr
approved these changes
Jan 29, 2024
6 tasks
alamb
approved these changes
Jan 29, 2024
Co-authored-by: Andrew Lamb <[email protected]>
# Conflicts: # datafusion/proto/tests/cases/roundtrip_physical_plan.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9028.
Rationale for this change
fn expressionsmethod of thenth_value_aggreturns missing information. For this reason,nth_value_aggcannot be decoded properly with protobuf. For more explanation see #9028. This PR fixes this problem.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?