Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workspace build with --no-default-features #9033

Closed
wants to merge 8 commits into from

Conversation

kmitchener
Copy link
Contributor

@kmitchener kmitchener commented Jan 28, 2024

Which issue does this PR close?

Closes #8844

Rationale for this change

This fixes the errors related to building without parquet support, mainly triggered by the datafusion-proto and datafusion-substrait crates. Prior to this PR, you couldn't run cargo build --no-default-features from the root of the workspace or cargo build -p datafusion-proto --no-default-features but now you can.

It still leaves warnings when compiling datafusion-proto without parquet support, but I may follow up on those in another PR. There's probably a better fix for those warnings than sprinkling cfg directives around.

What changes are included in this PR?

  • modified the prost build process to insert conditional compilation for the parquet crate on some message types
  • moved datafusion-benchmarks out of the workspace, because it requires the parquet feature to be functional
  • took the opportunity to make more specific includes based on the split crates rather than just 'datafusion'
  • updated the feature dependencies to use the 'dep:' syntax. optional dependencies still show up as implicit features -- using 'dep:' syntax removes these implicit features making DataFusion's feature list more intentional.implicitimplicit

Are these changes tested?

existing tests

Are there any user-facing changes?

No

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fmt
@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions core Core DataFusion crate labels Jan 28, 2024
@kmitchener kmitchener marked this pull request as draft January 29, 2024 16:54
@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) substrait labels Jan 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix
@kmitchener kmitchener changed the title improvement to build with --no-default-features fix workspace build with --no-default-features Jan 30, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Apr 13, 2024
@github-actions github-actions bot closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner sqllogictest SQL Logic Tests (.slt) Stale PR has not had any activity for some time substrait
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo build --no-default-features does not build cleanly
1 participant